RE: [PATCH v2 net] net: iosm: Prevent underflow in ipc_chnl_cfg_get()

["Kumar, M Chetan" <m.chetan.kumar@intel.com>]

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, August 16, 2021 4:44 PM
> To: Kumar, M Chetan <m.chetan.kumar@intel.com>; Solomon Ucko
> <solly.ucko@gmail.com>
> Cc: linuxwwan <linuxwwan@intel.com>; Loic Poulain
> <loic.poulain@linaro.org>; Sergey Ryazanov <ryazanov.s.a@gmail.com>;
> Johannes Berg <johannes@sipsolutions.net>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> netdev@vger.kernel.org; security@kernel.org
> Subject: [PATCH v2 net] net: iosm: Prevent underflow in ipc_chnl_cfg_get()
> 
> The bounds check on "index" doesn't catch negative values.  Using
> ARRAY_SIZE() directly is more readable and more robust because it prevents
> negative values for "index".  Fortunately we only pass valid values to
> ipc_chnl_cfg_get() so this patch does not affect runtime.
> 
> 
> Reported-by: Solomon Ucko <solly.ucko@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Remove underscore between "array" and "size".
>     Use %zu print format specifier to fix a compile warning on 32 bit.
> 
>  drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>