Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it
@ 2022-12-16 9:13 Daniil Tatianin
2022-12-16 11:20 ` Jiri Pirko
2022-12-19 21:24 ` Tony Nguyen
0 siblings, 2 replies; 3+ messages in thread
From: Daniil Tatianin @ 2022-12-16 9:13 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: Daniil Tatianin, Tony Nguyen, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Harshitha Ramamurthy, Jeff Kirsher, intel-wired-lan,
netdev, linux-kernel
This fixes a copy-paste issue where dev_err would log the dst mask even
though it is clearly talking about src.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index c4e451ef7942..adc02adef83a 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
field_flags |= IAVF_CLOUD_FIELD_IIP;
} else {
dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
- be32_to_cpu(match.mask->dst));
+ be32_to_cpu(match.mask->src));
return -EINVAL;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it
2022-12-16 9:13 [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it Daniil Tatianin
@ 2022-12-16 11:20 ` Jiri Pirko
2022-12-19 21:24 ` Tony Nguyen
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2022-12-16 11:20 UTC (permalink / raw)
To: Daniil Tatianin
Cc: Jesse Brandeburg, Tony Nguyen, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Harshitha Ramamurthy, Jeff Kirsher, intel-wired-lan,
netdev, linux-kernel
Fri, Dec 16, 2022 at 10:13:26AM CET, d-tatianin@yandex-team.ru wrote:
>This fixes a copy-paste issue where dev_err would log the dst mask even
>though it is clearly talking about src.
>
>Found by Linux Verification Center (linuxtesting.org) with the SVACE
>static analysis tool.
>
>Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters")
>Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it
2022-12-16 9:13 [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it Daniil Tatianin
2022-12-16 11:20 ` Jiri Pirko
@ 2022-12-19 21:24 ` Tony Nguyen
1 sibling, 0 replies; 3+ messages in thread
From: Tony Nguyen @ 2022-12-19 21:24 UTC (permalink / raw)
To: Daniil Tatianin, Jesse Brandeburg
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Harshitha Ramamurthy,
Jeff Kirsher, intel-wired-lan, netdev, linux-kernel
On 12/16/2022 1:13 AM, Daniil Tatianin wrote:
A couple of nits.
For the title, s/iavfs/iavf
> This fixes a copy-paste issue where dev_err would log the dst mask even
> though it is clearly talking about src.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Fixes: 0075fa0fadd0a ("i40evf: Add support to apply cloud filters")
This should just be 12 chars:
WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1>
("<title line>")' - ie: 'Fixes: 0075fa0fadd0 ("i40evf: Add support to
apply cloud filters")'
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index c4e451ef7942..adc02adef83a 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter,
> field_flags |= IAVF_CLOUD_FIELD_IIP;
> } else {
> dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n",
> - be32_to_cpu(match.mask->dst));
> + be32_to_cpu(match.mask->src));
> return -EINVAL;
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-19 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-16 9:13 [PATCH v1] iavfs/iavf_main: actually log ->src mask when talking about it Daniil Tatianin
2022-12-16 11:20 ` Jiri Pirko
2022-12-19 21:24 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).