Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt
@ 2021-06-04 3:22 dingsenjie
2021-06-04 7:49 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: dingsenjie @ 2021-06-04 3:22 UTC (permalink / raw)
To: richardcochran, andrew, hkallweit1, davem, kuba
Cc: netdev, linux-kernel, dingsenjie
From: dingsenjie <dingsenjie@yulong.com>
Simplify the return expression.
Signed-off-by: dingsenjie <dingsenjie@yulong.com>
---
drivers/net/phy/dp83640.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 0d79f68..bcd14ec 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1141,12 +1141,7 @@ static int dp83640_config_init(struct phy_device *phydev)
static int dp83640_ack_interrupt(struct phy_device *phydev)
{
- int err = phy_read(phydev, MII_DP83640_MISR);
-
- if (err < 0)
- return err;
-
- return 0;
+ return phy_read(phydev, MII_DP83640_MISR);
}
static int dp83640_config_intr(struct phy_device *phydev)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt
2021-06-04 3:22 [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt dingsenjie
@ 2021-06-04 7:49 ` Heiner Kallweit
2021-06-04 23:02 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2021-06-04 7:49 UTC (permalink / raw)
To: dingsenjie, richardcochran, andrew, davem, kuba
Cc: netdev, linux-kernel, dingsenjie
On 04.06.2021 05:22, dingsenjie@163.com wrote:
> From: dingsenjie <dingsenjie@yulong.com>
>
> Simplify the return expression.
>
> Signed-off-by: dingsenjie <dingsenjie@yulong.com>
> ---
> drivers/net/phy/dp83640.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
> index 0d79f68..bcd14ec 100644
> --- a/drivers/net/phy/dp83640.c
> +++ b/drivers/net/phy/dp83640.c
> @@ -1141,12 +1141,7 @@ static int dp83640_config_init(struct phy_device *phydev)
>
> static int dp83640_ack_interrupt(struct phy_device *phydev)
> {
> - int err = phy_read(phydev, MII_DP83640_MISR);
> -
> - if (err < 0)
> - return err;
> -
> - return 0;
> + return phy_read(phydev, MII_DP83640_MISR);
> }
>
> static int dp83640_config_intr(struct phy_device *phydev)
>
This would be a functional change. You'd return a positive value
instead of 0.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt
2021-06-04 7:49 ` Heiner Kallweit
@ 2021-06-04 23:02 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-06-04 23:02 UTC (permalink / raw)
To: Heiner Kallweit
Cc: dingsenjie, richardcochran, davem, kuba, netdev, linux-kernel,
dingsenjie
On Fri, Jun 04, 2021 at 09:49:17AM +0200, Heiner Kallweit wrote:
> On 04.06.2021 05:22, dingsenjie@163.com wrote:
> > From: dingsenjie <dingsenjie@yulong.com>
> >
> > Simplify the return expression.
> >
> > Signed-off-by: dingsenjie <dingsenjie@yulong.com>
> > ---
> > drivers/net/phy/dp83640.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
> > index 0d79f68..bcd14ec 100644
> > --- a/drivers/net/phy/dp83640.c
> > +++ b/drivers/net/phy/dp83640.c
> > @@ -1141,12 +1141,7 @@ static int dp83640_config_init(struct phy_device *phydev)
> >
> > static int dp83640_ack_interrupt(struct phy_device *phydev)
> > {
> > - int err = phy_read(phydev, MII_DP83640_MISR);
> > -
> > - if (err < 0)
> > - return err;
> > -
> > - return 0;
> > + return phy_read(phydev, MII_DP83640_MISR);
> > }
> >
> > static int dp83640_config_intr(struct phy_device *phydev)
> >
> This would be a functional change. You'd return a positive value
> instead of 0.
And looking a bit further down in the code:
static int dp83640_ack_interrupt(struct phy_device *phydev)
{
int err = phy_read(phydev, MII_DP83640_MISR);
if (err < 0)
return err;
return 0;
}
static int dp83640_config_intr(struct phy_device *phydev)
{
int micr;
int misr;
int err;
if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
err = dp83640_ack_interrupt(phydev);
if (err)
return err;
So a positive value is going to break the driver.
NACK
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 3:22 [PATCH] net: phy: Simplify the return expression of dp83640_ack_interrupt dingsenjie
2021-06-04 7:49 ` Heiner Kallweit
2021-06-04 23:02 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).