Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hayes Wang <hayeswang@realtek.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c
Date: Mon, 26 Jul 2021 10:37:28 +0200	[thread overview]
Message-ID: <YP50SIgqAEyKWSpA@kroah.com> (raw)
In-Reply-To: <c6b44f93a5b14fbb98d4c6cb0ed2a77f@realtek.com>

On Mon, Jul 26, 2021 at 08:26:00AM +0000, Hayes Wang wrote:
> Greg KH <gregkh@linuxfoundation.org>
> > Sent: Monday, July 26, 2021 3:37 PM
> [...]
> > That is a lot of different things all happening in one commit, why?
> 
> I plan to separate the file into two files. And
> I find I need an additional header file for it, so
> The patch includes adding that header file.

You also do other things, like renaming defines, which is not just
moving code around, right?

> > Please break this up into "one patch per change" and submit it that way.
> > 
> > But the real question is why break this file up in the first place?
> > What is wrong with the way it is today?  What future changes require
> > this file to be in smaller pieces?  If none, why make this?  If there
> > are future changes, then please submit this change when you submit
> > those, as that would show a real need.
> 
> The purpose is let me easy to maintain the driver.
> The code is larger and larger. And I find that the
> r8169.c has been separated into three files.
> Therefore, I think maybe I could split the driver
> into small parts like r8169. Then, the code wouldn't
> be complex.

I do not know, is it really easier to find things in 3 different files
instead of one?  That's up to you, but you did not say why this change
is needed.

thanks,

greg k-h

  reply	other threads:[~2021-07-26  8:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  9:18 [PATCH net-next 0/2] r8152: split the source code Hayes Wang
2021-07-13  9:18 ` [PATCH net-next 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2021-07-13  9:18 ` [PATCH net-next 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2021-07-26  4:01 ` [PATCH net-next RESEND 0/2] r8152: split the source code Hayes Wang
2021-07-26  4:01   ` [PATCH net-next RESEND 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2021-07-26  4:01   ` [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2021-07-26  7:36     ` Greg KH
2021-07-26  8:26       ` Hayes Wang
2021-07-26  8:37         ` Greg KH [this message]
2021-07-26 11:09           ` Hayes Wang
2021-07-26 11:14             ` Greg KH
2021-07-26 11:43               ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP50SIgqAEyKWSpA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --subject='Re: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).