Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: asmadeus@codewreck.org
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Harshvardhan Jha <harshvardhan.jha@oracle.com>,
	ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
	kuba@kernel.org, v9fs-developer@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry
Date: Tue, 27 Jul 2021 08:59:53 +0900	[thread overview]
Message-ID: <YP9MeeqOKcyYRxjK@codewreck.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2107261654130.10122@sstabellini-ThinkPad-T480s>

Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700:
> > > Yes, I did test it successfully. Aside from the commit messaged to be
> > > reworded:
> > How's this?
> > ===========================BEGIN========================================
> > 9p/xen: Fix end of loop tests for list_for_each_entry
> > 
> > This patch addresses the following problems:
> >  - priv can never be NULL, so this part of the check is useless
> >  - if the loop ran through the whole list, priv->client is invalid and
> > it is more appropriate and sufficient to check for the end of
> > list_for_each_entry loop condition.
> > 
> > Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>

Will take the patch with this text as commit message later tonight


> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > Tested-by: Stefano Stabellini <sstabellini@kernel.org>

Thanks for the test!

-- 
Dominique

  reply	other threads:[~2021-07-27  0:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 17:51 Harshvardhan Jha
2021-07-25 20:46 ` asmadeus
2021-07-26 21:30   ` Stefano Stabellini
2021-07-26 22:23     ` [External] : " Harshvardhan Jha
2021-07-26 23:54       ` Stefano Stabellini
2021-07-26 23:59         ` asmadeus [this message]
2021-07-27  0:01           ` Harshvardhan Jha
2021-07-27  0:07         ` Harshvardhan Jha
2021-07-27 14:07           ` asmadeus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP9MeeqOKcyYRxjK@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=davem@davemloft.net \
    --cc=ericvh@gmail.com \
    --cc=harshvardhan.jha@oracle.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=netdev@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    --subject='Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).