From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24460C4338F for ; Tue, 27 Jul 2021 00:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1DCE60F93 for ; Tue, 27 Jul 2021 00:00:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234187AbhGZXT4 (ORCPT ); Mon, 26 Jul 2021 19:19:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233770AbhGZXTz (ORCPT ); Mon, 26 Jul 2021 19:19:55 -0400 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798B8C061757; Mon, 26 Jul 2021 17:00:23 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 108) id AB434C01F; Tue, 27 Jul 2021 02:00:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1627344017; bh=AqWBIB/P4cglBp3v+EdtFD5gnv4amdJeHzvQ+TsnBuU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JlDKAnlU39KnHu8bxfIxaZRWzNJQfxcS0j5Cpgs2W1tAzNLhN7Cy1Ida9gcfAg848 Pn0w6gXZoPYmJ24Z+B8YI53JCMgaYRoVGqtk8xcEXHGwPxlPILXsEWSPDKhVTzUow8 90vgG2cRgHIrgte/Os5377+aoHAt8puIOf4asPsPldGH77Qpn4S5Jwxv3JJgQa7Iqd dR42VJUX5U2oHLJjBVU43lZNo2FyoYVQEqV5G5STknNkj4i9tBw2RkDo4IxVxtxPlj QLtM8qbwcm1alScM2SOuUdIjMePmlIVSX0KXGe63LhXnPqD4kFOIl4s1Fe7A9KGB3n vlM6gvXEulfsA== Received: from odin.codewreck.org (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 4FEBEC009; Tue, 27 Jul 2021 02:00:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1627344017; bh=AqWBIB/P4cglBp3v+EdtFD5gnv4amdJeHzvQ+TsnBuU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JlDKAnlU39KnHu8bxfIxaZRWzNJQfxcS0j5Cpgs2W1tAzNLhN7Cy1Ida9gcfAg848 Pn0w6gXZoPYmJ24Z+B8YI53JCMgaYRoVGqtk8xcEXHGwPxlPILXsEWSPDKhVTzUow8 90vgG2cRgHIrgte/Os5377+aoHAt8puIOf4asPsPldGH77Qpn4S5Jwxv3JJgQa7Iqd dR42VJUX5U2oHLJjBVU43lZNo2FyoYVQEqV5G5STknNkj4i9tBw2RkDo4IxVxtxPlj QLtM8qbwcm1alScM2SOuUdIjMePmlIVSX0KXGe63LhXnPqD4kFOIl4s1Fe7A9KGB3n vlM6gvXEulfsA== Received: from localhost (odin.codewreck.org [local]) by odin.codewreck.org (OpenSMTPD) with ESMTPA id 7ce8ee03; Tue, 27 Jul 2021 00:00:08 +0000 (UTC) Date: Tue, 27 Jul 2021 08:59:53 +0900 From: asmadeus@codewreck.org To: Stefano Stabellini Cc: Harshvardhan Jha , ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net, kuba@kernel.org, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry Message-ID: References: <20210725175103.56731-1-harshvardhan.jha@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700: > > > Yes, I did test it successfully. Aside from the commit messaged to be > > > reworded: > > How's this? > > ===========================BEGIN======================================== > > 9p/xen: Fix end of loop tests for list_for_each_entry > > > > This patch addresses the following problems: > > - priv can never be NULL, so this part of the check is useless > > - if the loop ran through the whole list, priv->client is invalid and > > it is more appropriate and sufficient to check for the end of > > list_for_each_entry loop condition. > > > > Signed-off-by: Harshvardhan Jha Will take the patch with this text as commit message later tonight > > > Reviewed-by: Stefano Stabellini > > > Tested-by: Stefano Stabellini Thanks for the test! -- Dominique