From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 444CFC4320A for ; Tue, 27 Jul 2021 02:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21C5A60FED for ; Tue, 27 Jul 2021 02:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234506AbhG0CES (ORCPT ); Mon, 26 Jul 2021 22:04:18 -0400 Received: from maynard.decadent.org.uk ([95.217.213.242]:43920 "EHLO maynard.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233727AbhG0CEQ (ORCPT ); Mon, 26 Jul 2021 22:04:16 -0400 X-Greylist: delayed 1459 seconds by postgrey-1.27 at vger.kernel.org; Mon, 26 Jul 2021 22:04:16 EDT Received: from 168.7-181-91.adsl-dyn.isp.belgacom.be ([91.181.7.168] helo=deadeye) by maynard with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8Chj-0007ER-B8; Tue, 27 Jul 2021 04:20:23 +0200 Received: from ben by deadeye with local (Exim 4.94.2) (envelope-from ) id 1m8Chi-000cTJ-KA; Tue, 27 Jul 2021 04:20:22 +0200 Date: Tue, 27 Jul 2021 04:20:22 +0200 From: Ben Hutchings To: Marcelo Ricardo Leitner Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, Ilja Van Sprundel , Neil Horman , Vlad Yasevich , Xin Long , carnil@debian.org Subject: Re: [PATCH net 1/4] sctp: validate from_addr_param return Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l8KlNNhMC8kbt7or" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 91.181.7.168 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on maynard); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --l8KlNNhMC8kbt7or Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 28, 2021 at 04:13:41PM -0300, Marcelo Ricardo Leitner wrote: [...] > @@ -1174,7 +1175,8 @@ static struct sctp_association *__sctp_rcv_asconf_l= ookup( > if (unlikely(!af)) > return NULL; > =20 > - af->from_addr_param(&paddr, param, peer_port, 0); > + if (af->from_addr_param(&paddr, param, peer_port, 0)) > + return NULL; > =20 > return __sctp_lookup_association(net, laddr, &paddr, transportp); > } [...] This condition needs to be inverted, doesn't it? Ben. --=20 Ben Hutchings friends: People who know you well, but like you anyway. --l8KlNNhMC8kbt7or Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAmD/bWEACgkQ57/I7JWG EQkoVw/9EGrgEYZ3OHwwXGI2peGZ3V0z/R0pYw7Jpvs5skI49MeuwZdHMXB3h+Kf 57nYT9Sy+mOI8ilvlBcXpTimv4Nnog4nv2cT/GX7VpxcWeegQDBLpCqAdOF4C64S gc078OeX2DTq0nc59cdookKN1Z3QKdpNshw9WrPOPdX7lWeB93UB2DZENpM4Q+N1 dDM35HSuCYzotfgyryuAY1khHJHgN7f4MloZfIskKPlsBitSPA4SwtR2FafyNohA nyAot0de8WMx7wdNCYVdK7TfL2KgVuaXakMkQpVOSynv2aVigeDPkw0NXruanAPx dCF+LvdKVbxuD7XwTmdmRovMsuMG9fzYFYe2szNUVvw0aN9JFWs2TCc00clqhvyU XMn+XxMJMCZS+fbsuKjOCDgxn4wxVaWyFzys0xMyPvAjnMOig4r91gkzgxVwV6zq TYIB0lUIFwszNHOjqugEHXrx4Ks0lNxIz28eDdoEXewabDFkVpt6jJGg/dEmFOqx 5Izr9uRhJ2Mcj5IXJQegCLzRp9eeYzFg9YdmQ4Jkc2CGNCG3uuzue7xowPsh0Da8 KxgqM04QL7GsFk4wDvukNstlKyB2aD9pdoKR3niRWQKC7R9k4aToWdht6loZx+eS Ewemb1LmsRXFOu+UtEy5ZS0nGC9bl2siqap38G/KFFtxYEqfqlA= =lAh5 -----END PGP SIGNATURE----- --l8KlNNhMC8kbt7or--