Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Johan Hovold <johan@kernel.org>,
	Oliver Neukum <oneukum@suse.com>,
	Anirudh Rayabharam <mail@anirudhrb.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Rustam Kovhaev <rkovhaev@gmail.com>,
	Zheng Yongjun <zhengyongjun3@huawei.com>,
	Emil Renner Berthing <kernel@esmil.dk>,
	syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com,
	YueHaibing <yuehaibing@huawei.com>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device
Date: Wed, 21 Jul 2021 09:36:06 +0200	[thread overview]
Message-ID: <YPfOZp7YoagbE+Mh@kroah.com> (raw)
In-Reply-To: <20210714091327.677458-1-mudongliangabcd@gmail.com>

On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote:
> The current error handling code of hso_create_net_device is
> hso_free_net_device, no matter which errors lead to. For example,
> WARNING in hso_free_net_device [1].
> 
> Fix this by refactoring the error handling code of
> hso_create_net_device by handling different errors by different code.
> 
> [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe
> 
> Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com
> Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> v1->v2: change labels according to the comment of Dan Carpenter
> v2->v3: change the style of error handling labels
>  drivers/net/usb/hso.c | 33 +++++++++++++++++++++++----------
>  1 file changed, 23 insertions(+), 10 deletions(-)

Please resend the whole series, not just one patch of the series.
Otherwise it makes it impossible to determine what patch from what
series should be applied in what order.

All of these are now dropped from my queue, please fix up and resend.

thanks,

greg k-h

  reply	other threads:[~2021-07-21  7:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  9:13 Dongliang Mu
2021-07-21  7:36 ` Greg Kroah-Hartman [this message]
2021-07-21  8:17   ` Dongliang Mu
2021-07-21 14:34     ` Johan Hovold
2021-07-21 16:42       ` Johan Hovold
2021-07-22  5:32         ` Dongliang Mu
2021-07-22  7:23           ` Johan Hovold
2021-07-22  7:51             ` Dongliang Mu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPfOZp7YoagbE+Mh@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=johan@kernel.org \
    --cc=kernel@esmil.dk \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@anirudhrb.com \
    --cc=mudongliangabcd@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=rkovhaev@gmail.com \
    --cc=syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com \
    --cc=yuehaibing@huawei.com \
    --cc=zhengyongjun3@huawei.com \
    --subject='Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).