From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59502C07E9B for ; Wed, 21 Jul 2021 07:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36C1C61175 for ; Wed, 21 Jul 2021 07:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235406AbhGUG4e (ORCPT ); Wed, 21 Jul 2021 02:56:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:35236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234361AbhGUGzc (ORCPT ); Wed, 21 Jul 2021 02:55:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE907606A5; Wed, 21 Jul 2021 07:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626852968; bh=KlmLkL59OiWSTy83kBXJsEldlUQA0yf4WquevwiPQnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nUKzA/Q+07YyD48Aekk1WulMlHGmOFP4xtq0/4OAkFmryLTnrmKDKz7k66khqk2rC oO95Y+4krxmBfFk/jBHP3WsxmqMysPAcwSI3TM69ti/e8ZyHigNdqQjsOCKyUK1ZKI dtMENVDxIMvVcTXElA4HdS9bAPgWxeMTDN8XYHCw= Date: Wed, 21 Jul 2021 09:36:06 +0200 From: Greg Kroah-Hartman To: Dongliang Mu Cc: "David S. Miller" , Jakub Kicinski , Johan Hovold , Oliver Neukum , Anirudh Rayabharam , Dan Carpenter , Rustam Kovhaev , Zheng Yongjun , Emil Renner Berthing , syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com, YueHaibing , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device Message-ID: References: <20210714091327.677458-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210714091327.677458-1-mudongliangabcd@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote: > The current error handling code of hso_create_net_device is > hso_free_net_device, no matter which errors lead to. For example, > WARNING in hso_free_net_device [1]. > > Fix this by refactoring the error handling code of > hso_create_net_device by handling different errors by different code. > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe > > Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe") > Signed-off-by: Dongliang Mu > --- > v1->v2: change labels according to the comment of Dan Carpenter > v2->v3: change the style of error handling labels > drivers/net/usb/hso.c | 33 +++++++++++++++++++++++---------- > 1 file changed, 23 insertions(+), 10 deletions(-) Please resend the whole series, not just one patch of the series. Otherwise it makes it impossible to determine what patch from what series should be applied in what order. All of these are now dropped from my queue, please fix up and resend. thanks, greg k-h