Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Oliver Neukum <oneukum@suse.com>,
	Anirudh Rayabharam <mail@anirudhrb.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Rustam Kovhaev <rkovhaev@gmail.com>,
	Zheng Yongjun <zhengyongjun3@huawei.com>,
	Emil Renner Berthing <kernel@esmil.dk>,
	syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com,
	YueHaibing <yuehaibing@huawei.com>,
	linux-usb@vger.kernel.org,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device
Date: Wed, 21 Jul 2021 16:34:56 +0200	[thread overview]
Message-ID: <YPgwkEHzmxSPSLVA@hovoldconsulting.com> (raw)
In-Reply-To: <CAD-N9QVi=TvS6sM+jcOf=Y5esECtRgTMgdFW+dqB-R_BuNv6AQ@mail.gmail.com>

On Wed, Jul 21, 2021 at 04:17:01PM +0800, Dongliang Mu wrote:
> On Wed, Jul 21, 2021 at 3:36 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote:
> > > The current error handling code of hso_create_net_device is
> > > hso_free_net_device, no matter which errors lead to. For example,
> > > WARNING in hso_free_net_device [1].
> > >
> > > Fix this by refactoring the error handling code of
> > > hso_create_net_device by handling different errors by different code.
> > >
> > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe
> > >
> > > Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com
> > > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe")
> > > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > > ---
> > > v1->v2: change labels according to the comment of Dan Carpenter
> > > v2->v3: change the style of error handling labels
> > >  drivers/net/usb/hso.c | 33 +++++++++++++++++++++++----------
> > >  1 file changed, 23 insertions(+), 10 deletions(-)
> >
> > Please resend the whole series, not just one patch of the series.
> > Otherwise it makes it impossible to determine what patch from what
> > series should be applied in what order.
> >
> 
> Done. Please review the resend v3 patches.
> 
> > All of these are now dropped from my queue, please fix up and resend.

A version of this patch has already been applied to net-next.

No idea which version that was or why the second patch hasn't been
applied yet.

Dongliang, if you're resending something here it should first be rebased
on linux-next (net-next).

Johan

  reply	other threads:[~2021-07-21 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  9:13 Dongliang Mu
2021-07-21  7:36 ` Greg Kroah-Hartman
2021-07-21  8:17   ` Dongliang Mu
2021-07-21 14:34     ` Johan Hovold [this message]
2021-07-21 16:42       ` Johan Hovold
2021-07-22  5:32         ` Dongliang Mu
2021-07-22  7:23           ` Johan Hovold
2021-07-22  7:51             ` Dongliang Mu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPgwkEHzmxSPSLVA@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@esmil.dk \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@anirudhrb.com \
    --cc=mudongliangabcd@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=rkovhaev@gmail.com \
    --cc=syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com \
    --cc=yuehaibing@huawei.com \
    --cc=zhengyongjun3@huawei.com \
    --subject='Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).