From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8517BC636C9 for ; Wed, 21 Jul 2021 14:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69ADB6121F for ; Wed, 21 Jul 2021 14:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238608AbhGUNyu (ORCPT ); Wed, 21 Jul 2021 09:54:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:50838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232160AbhGUNyo (ORCPT ); Wed, 21 Jul 2021 09:54:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21FCC608FE; Wed, 21 Jul 2021 14:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626878121; bh=bEM+kDm2sLkva1f/QePZ/LyZfm2n730ykL+StucW3ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XaZY1Y0Uu9xYrizou2TN6tDrFFre1EX7/JOKy20nmzenJkpFQ/XI3b/NLyWB5MW2/ RV7fqYs9ajGXZPAi6NOH5SlGA+8DICv5248q65Sypk5Ht7Ofoum0Pv5L5VGZTMhr44 AQY8Sb1a3IJcAKn5ZiN6CxPTPkQHoPeY7n5eSbpHsp0rulcj1f62EeODhOZmKC3dye eQi2gkX9R8JT6LaSOEr2rWeruOfMkaDdX5SC3lW/G6gtPsdAplPib9OvIBNL0DgrJ7 3MBcsB0tghTImTciCDuvTUhs7vsN4qOC0i4pBVWKW0MX6QNYNbiMORPwe277qr1D6+ AUSTQ72+zACpg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1m6DJI-0001Iz-0j; Wed, 21 Jul 2021 16:34:56 +0200 Date: Wed, 21 Jul 2021 16:34:56 +0200 From: Johan Hovold To: Dongliang Mu Cc: Greg Kroah-Hartman , "David S. Miller" , Jakub Kicinski , Oliver Neukum , Anirudh Rayabharam , Dan Carpenter , Rustam Kovhaev , Zheng Yongjun , Emil Renner Berthing , syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com, YueHaibing , linux-usb@vger.kernel.org, "open list:NETWORKING [GENERAL]" , linux-kernel Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device Message-ID: References: <20210714091327.677458-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 21, 2021 at 04:17:01PM +0800, Dongliang Mu wrote: > On Wed, Jul 21, 2021 at 3:36 PM Greg Kroah-Hartman > wrote: > > > > On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote: > > > The current error handling code of hso_create_net_device is > > > hso_free_net_device, no matter which errors lead to. For example, > > > WARNING in hso_free_net_device [1]. > > > > > > Fix this by refactoring the error handling code of > > > hso_create_net_device by handling different errors by different code. > > > > > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe > > > > > > Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com > > > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe") > > > Signed-off-by: Dongliang Mu > > > --- > > > v1->v2: change labels according to the comment of Dan Carpenter > > > v2->v3: change the style of error handling labels > > > drivers/net/usb/hso.c | 33 +++++++++++++++++++++++---------- > > > 1 file changed, 23 insertions(+), 10 deletions(-) > > > > Please resend the whole series, not just one patch of the series. > > Otherwise it makes it impossible to determine what patch from what > > series should be applied in what order. > > > > Done. Please review the resend v3 patches. > > > All of these are now dropped from my queue, please fix up and resend. A version of this patch has already been applied to net-next. No idea which version that was or why the second patch hasn't been applied yet. Dongliang, if you're resending something here it should first be rebased on linux-next (net-next). Johan