Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: andrew@lunn.ch, davem@davemloft.net, f.fainelli@gmail.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, olteanv@gmail.com,
	vivien.didelot@gmail.com
Subject: Re: [RFC] dsa: register every port with of_platform
Date: Fri, 23 Jul 2021 13:30:18 +0200	[thread overview]
Message-ID: <YPqoSlzdZhPdyUKN@Ansuel-xps.localdomain> (raw)
In-Reply-To: <168cb1440ebe1cff4a7b5e343502638a@walle.cc>

On Fri, Jul 23, 2021 at 01:25:02PM +0200, Michael Walle wrote:
> Am 2021-07-23 13:18, schrieb Ansuel Smith:
> > On Fri, Jul 23, 2021 at 01:13:28PM +0200, Michael Walle wrote:
> > > > The declaration of a different mac-addr using the nvmem framework is
> > > > currently broken. The dsa code uses the generic of_get_mac_address where
> > > > the nvmem function requires the device node to be registered in the
> > > > of_platform to be found by of_find_device_by_node. Register every port
> > > 
> > > Which tree are you on? This should be fixed with
> > > 
> > > f10843e04a07  of: net: fix of_get_mac_addr_nvmem() for non-platform
> > > devices
> > > 
> > > -michael
> > 
> > Thx a lot for the hint. So yes I missed that the problem was already
> > fixed. Sorry for the mess. Any idea if that will be backported?
> 
> I didn't include a Fixes tag, so it won't be automatically
> backported. Also I'm not sure if it qualifies for the stable trees
> because no in-tree users seem to be affected, no?
> 
> -michael

Also the patch seems very large. Anyway again thx a lot for the work and
the quick hint. Time to backport to 5.10 and 5.4 for openwrt.


      reply	other threads:[~2021-07-23 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 11:05 Ansuel Smith
2021-07-23 11:13 ` Michael Walle
2021-07-23 11:18   ` Ansuel Smith
2021-07-23 11:25     ` Michael Walle
2021-07-23 11:30       ` Ansuel Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPqoSlzdZhPdyUKN@Ansuel-xps.localdomain \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    --subject='Re: [RFC] dsa: register every port with of_platform' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).