Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Luo Jie <luoj@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
	davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
	robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
Date: Sun, 8 Aug 2021 17:47:55 +0200	[thread overview]
Message-ID: <YQ/8q6gR6Eji2hKD@lunn.ch> (raw)
In-Reply-To: <20210808075328.30961-1-luoj@codeaurora.org>

On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
> The new added properties resource "reg" is for configuring
> ethernet LDO in the IPQ5018 chipset, the property "clocks"
> is for configuring the MDIO clock source frequency.
> 
> This patch depends on the following patch:
> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
> driver")

Please always make binding patches part of the series containing the
driver code. We sometimes need to see both to do a proper review.

Add a comment about when the second address range and clock is
required. Does qcom,ipq5018-mdio require them?

	  Andrew

  reply	other threads:[~2021-08-08 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  7:53 Luo Jie
2021-08-08 15:47 ` Andrew Lunn [this message]
2021-08-09 13:06   ` Jie Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ/8q6gR6Eji2hKD@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luoj@codeaurora.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=sricharan@codeaurora.org \
    --subject='Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).