Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
@ 2021-08-08  7:53 Luo Jie
  2021-08-08 15:47 ` Andrew Lunn
  0 siblings, 1 reply; 3+ messages in thread
From: Luo Jie @ 2021-08-08  7:53 UTC (permalink / raw)
  To: agross, bjorn.andersson, davem, kuba, robh+dt, robert.marko
  Cc: linux-arm-msm, netdev, devicetree, linux-kernel, sricharan, Luo Jie

The new added properties resource "reg" is for configuring
ethernet LDO in the IPQ5018 chipset, the property "clocks"
is for configuring the MDIO clock source frequency.

This patch depends on the following patch:
Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
driver")

Signed-off-by: Luo Jie <luoj@codeaurora.org>
---
 .../devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
index 0c973310ada0..8f53fa2a00f8 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
@@ -14,7 +14,9 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,ipq4019-mdio
+    enum:
+      - qcom,ipq4019-mdio
+      - qcom,ipq5018-mdio
 
   "#address-cells":
     const: 1
@@ -23,7 +25,15 @@ properties:
     const: 0
 
   reg:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
+    description:
+      the first Address and length of the register set for the MDIO controller.
+      the optional second Address and length of the register for ethernet LDO.
+
+  clocks:
+    items:
+      - description: MDIO clock
 
 required:
   - compatible
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
  2021-08-08  7:53 [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO Luo Jie
@ 2021-08-08 15:47 ` Andrew Lunn
  2021-08-09 13:06   ` Jie Luo
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2021-08-08 15:47 UTC (permalink / raw)
  To: Luo Jie
  Cc: agross, bjorn.andersson, davem, kuba, robh+dt, robert.marko,
	linux-arm-msm, netdev, devicetree, linux-kernel, sricharan

On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
> The new added properties resource "reg" is for configuring
> ethernet LDO in the IPQ5018 chipset, the property "clocks"
> is for configuring the MDIO clock source frequency.
> 
> This patch depends on the following patch:
> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
> driver")

Please always make binding patches part of the series containing the
driver code. We sometimes need to see both to do a proper review.

Add a comment about when the second address range and clock is
required. Does qcom,ipq5018-mdio require them?

	  Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
  2021-08-08 15:47 ` Andrew Lunn
@ 2021-08-09 13:06   ` Jie Luo
  0 siblings, 0 replies; 3+ messages in thread
From: Jie Luo @ 2021-08-09 13:06 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: agross, bjorn.andersson, davem, kuba, robh+dt, robert.marko,
	linux-arm-msm, netdev, devicetree, linux-kernel, sricharan


On 8/8/2021 11:47 PM, Andrew Lunn wrote:
> On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
>> The new added properties resource "reg" is for configuring
>> ethernet LDO in the IPQ5018 chipset, the property "clocks"
>> is for configuring the MDIO clock source frequency.
>>
>> This patch depends on the following patch:
>> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
>> driver")
> Please always make binding patches part of the series containing the
> driver code. We sometimes need to see both to do a proper review.
>
> Add a comment about when the second address range and clock is
> required. Does qcom,ipq5018-mdio require them?
>
> 	  Andrew

Hi Andrew,

yes, the second address range is only required for qcom,ipq5018-mdio 
currently,

will document it in next patch set, and send it with the drive code 
patch, thanks

for the comments and review.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-09 13:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-08  7:53 [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO Luo Jie
2021-08-08 15:47 ` Andrew Lunn
2021-08-09 13:06   ` Jie Luo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).