From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13C0C4338F for ; Sat, 31 Jul 2021 08:04:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA1FA60F00 for ; Sat, 31 Jul 2021 08:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbhGaIEd (ORCPT ); Sat, 31 Jul 2021 04:04:33 -0400 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:47661 "EHLO wnew1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbhGaIDW (ORCPT ); Sat, 31 Jul 2021 04:03:22 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id AD67E2B01381; Sat, 31 Jul 2021 04:03:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 31 Jul 2021 04:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=HaF70jJIwVgzmQByN2MvzfEuB4C s9uu4puwwbbsEWXw=; b=ip8Zjpp4kk00bDvde12tpXFrWj0X4lVgrydAqKkTAjT h9URjOHRfTjL7DIAr5cpe5JplyV5UAnC+glL2m3hPIbchgsw2UfoSyNacOjNxRWP M49SkMwrPdH0UadqcSyOivFkkB0H6gt27b2yLVg9oVNMA366LiWU/1/sXA/dYW1q wvzNncf8r9AyVTknFRVp4LUI3/DSaD6PYAPmc/7lJ8thVNbHlEcIyZFjfrj6/SM0 zmYIND8ED8YFuDcbTCrCfC4Sn2rfJfRubuYDWOgz1Exm5I+eLpKRVFd8PL4Uao+n Ia0KMjckOHCt5oEJyXLWBBxJoa4Ut+mqvzvnQd6HZTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=HaF70j JIwVgzmQByN2MvzfEuB4Cs9uu4puwwbbsEWXw=; b=cOXjQgJ+LZFOUBUQ64WiZ9 6d3lpXS1wQrsTMQupnbwQY9A/BJ441TxcmjURvDcCZdNhnoVUw++5Gzut/rKGwe6 G/g6S3k6/OVHhEp1xW9XkGds1nkzVzp93R4hgJELe6nrLTpL2eOW8gR6h4UzM8sK p08x4X46dyt5iZ+GMtZGFBdFSK3FLTlOR7d9dnnOtrclh/A9onoOoKJhRWlVD9+I qptKNmVhYceSwzFN02NvtZ3E7M8NEnlM/6zlSlYUZaLJ1EtQ/6Unql45wgmsee4y O6ezVGKreStnjVf8KtirC881XTl2m1ETMSieJBJVFKpszx7Axz1+jI1/65i0Vq4w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheeigdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdortddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpedutdeivd ejgedufffgvdfhtdejuefghfehvdejhefggfeludeugfefkeegvdelhfenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 31 Jul 2021 04:03:01 -0400 (EDT) Date: Sat, 31 Jul 2021 10:02:58 +0200 From: Greg KH To: Kalle Valo Cc: Nguyen Dinh Phi , johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update Message-ID: References: <20210628132334.851095-1-phind.uet@gmail.com> <877dh6dimf.fsf@tynnyri.adurom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877dh6dimf.fsf@tynnyri.adurom.net> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jul 31, 2021 at 10:53:28AM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote: > >> When we exceed the limit of BSS entries, this function will free the > >> new entry, however, at this time, it is the last door to access the > >> inputed ies, so these ies will be unreferenced objects and cause memory > >> leak. > >> Therefore we should free its ies before deallocating the new entry, beside > >> of dropping it from hidden_list. > >> > >> Signed-off-by: Nguyen Dinh Phi > > [...] > > > Did this change get lost somewhere? > > Johannes applied it to the macc80211 tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff > > Ah, and it's already in Linus' tree as well. Ah, thanks, I had missed that it just landed there. greg k-h