Re: [PATCH net] nfp: update ethtool reporting of pauseframe control

[Andrew Lunn <andrew@lunn.ch>]

On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> From: Fei Qin <fei.qin@corigine.com>
> 
> Pauseframe control is set to symmetric mode by default on the NFP.
> Pause frames can not be configured through ethtool now, but ethtool can
> report the supported mode.
> 
> Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> Signed-off-by: Fei Qin <fei.qin@corigine.com>
> Signed-off-by: Louis Peens <louis.peens@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index 1b482446536d..8803faadd302 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
>  
>  	/* Init to unknowns */
>  	ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> +	ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> +	ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);

Hi Simon

Does it act on the results of the pause auto-neg? If the link peer
says it does not support pause, will it turn pause off?

     Andrew