Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	UNGLinuxDriver@microchip.com,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs
Date: Tue, 10 Aug 2021 14:49:49 +0200	[thread overview]
Message-ID: <YRJ17eMJPjx2fOtm@piout.net> (raw)
In-Reply-To: <20210810123748.47871-1-broonie@kernel.org>

On 10/08/2021 13:37:48+0100, Mark Brown wrote:
> The ocelot driver makes use of regmap, wrapping it with driver specific
> operations that are thin wrappers around the core regmap APIs. These are
> exported with EXPORT_SYMBOL, dropping the _GPL from the core regmap
> exports which is frowned upon. Add _GPL suffixes to at least the APIs that
> are doing register I/O.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/net/ethernet/mscc/ocelot_io.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mscc/ocelot_io.c b/drivers/net/ethernet/mscc/ocelot_io.c
> index ea4e83410fe4..7390fa3980ec 100644
> --- a/drivers/net/ethernet/mscc/ocelot_io.c
> +++ b/drivers/net/ethernet/mscc/ocelot_io.c
> @@ -21,7 +21,7 @@ u32 __ocelot_read_ix(struct ocelot *ocelot, u32 reg, u32 offset)
>  		    ocelot->map[target][reg & REG_MASK] + offset, &val);
>  	return val;
>  }
> -EXPORT_SYMBOL(__ocelot_read_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_read_ix);
>  
>  void __ocelot_write_ix(struct ocelot *ocelot, u32 val, u32 reg, u32 offset)
>  {
> @@ -32,7 +32,7 @@ void __ocelot_write_ix(struct ocelot *ocelot, u32 val, u32 reg, u32 offset)
>  	regmap_write(ocelot->targets[target],
>  		     ocelot->map[target][reg & REG_MASK] + offset, val);
>  }
> -EXPORT_SYMBOL(__ocelot_write_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_write_ix);
>  
>  void __ocelot_rmw_ix(struct ocelot *ocelot, u32 val, u32 mask, u32 reg,
>  		     u32 offset)
> @@ -45,7 +45,7 @@ void __ocelot_rmw_ix(struct ocelot *ocelot, u32 val, u32 mask, u32 reg,
>  			   ocelot->map[target][reg & REG_MASK] + offset,
>  			   mask, val);
>  }
> -EXPORT_SYMBOL(__ocelot_rmw_ix);
> +EXPORT_SYMBOL_GPL(__ocelot_rmw_ix);
>  
>  u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
>  {
> @@ -58,7 +58,7 @@ u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
>  	regmap_read(port->target, ocelot->map[target][reg & REG_MASK], &val);
>  	return val;
>  }
> -EXPORT_SYMBOL(ocelot_port_readl);
> +EXPORT_SYMBOL_GPL(ocelot_port_readl);
>  
>  void ocelot_port_writel(struct ocelot_port *port, u32 val, u32 reg)
>  {
> @@ -69,7 +69,7 @@ void ocelot_port_writel(struct ocelot_port *port, u32 val, u32 reg)
>  
>  	regmap_write(port->target, ocelot->map[target][reg & REG_MASK], val);
>  }
> -EXPORT_SYMBOL(ocelot_port_writel);
> +EXPORT_SYMBOL_GPL(ocelot_port_writel);
>  
>  void ocelot_port_rmwl(struct ocelot_port *port, u32 val, u32 mask, u32 reg)
>  {
> @@ -77,7 +77,7 @@ void ocelot_port_rmwl(struct ocelot_port *port, u32 val, u32 mask, u32 reg)
>  
>  	ocelot_port_writel(port, (cur & (~mask)) | val, reg);
>  }
> -EXPORT_SYMBOL(ocelot_port_rmwl);
> +EXPORT_SYMBOL_GPL(ocelot_port_rmwl);
>  
>  u32 __ocelot_target_read_ix(struct ocelot *ocelot, enum ocelot_target target,
>  			    u32 reg, u32 offset)
> @@ -128,7 +128,7 @@ int ocelot_regfields_init(struct ocelot *ocelot,
>  
>  	return 0;
>  }
> -EXPORT_SYMBOL(ocelot_regfields_init);
> +EXPORT_SYMBOL_GPL(ocelot_regfields_init);
>  
>  static struct regmap_config ocelot_regmap_config = {
>  	.reg_bits	= 32,
> @@ -148,4 +148,4 @@ struct regmap *ocelot_regmap_init(struct ocelot *ocelot, struct resource *res)
>  
>  	return devm_regmap_init_mmio(ocelot->dev, regs, &ocelot_regmap_config);
>  }
> -EXPORT_SYMBOL(ocelot_regmap_init);
> +EXPORT_SYMBOL_GPL(ocelot_regmap_init);
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-08-10 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 12:37 Mark Brown
2021-08-10 12:49 ` Alexandre Belloni [this message]
2021-08-10 12:55 ` Vladimir Oltean
2021-08-10 14:34   ` Mark Brown
2021-08-11 22:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRJ17eMJPjx2fOtm@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --subject='Re: [PATCH] net: mscc: Fix non-GPL export of regmap APIs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).