Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))
Date: Wed, 11 Aug 2021 15:50:30 +0300	[thread overview]
Message-ID: <YRPHlsmBv66r4+vD@smile.fi.intel.com> (raw)
In-Reply-To: <CAHNKnsQOhpwLFHLbcyLDLDOQjD7uDdsOg4ptVpdVmwWHK01NwQ@mail.gmail.com>

On Fri, Aug 06, 2021 at 11:35:04PM +0300, Sergey Ryazanov wrote:
> On Fri, Aug 6, 2021 at 5:20 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Fri, Aug 6, 2021 at 5:14 PM Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
> >> On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko
> >> <andriy.shevchenko@linux.intel.com> wrote:
> >>> ida_alloc_range)) may return other than -ENOMEM error code.
> >>> Unshadow it in the wwan_create_port().
> >>>
> >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >>
> >> A small nitpick, looks like "ida_alloc_range))" in the description is
> >> a typo and should be "ida_alloc_range()". Besides this:
> >
> > Shall I resend?
> 
> Yes, please. And specify the target tree in the subject, please. See
> patchwork warning [1, 2]. The first patch is a clear bug fix, so it
> should be targeted to the 'net' tree, while the second patch despite
> its usefulness could not be considered a bug fix, so it should be
> targeted to the 'net-next' tree. Subjects could be like this:
> 
> [PATCHv3 net 1/2] wwan: core: Avoid returning NULL from wwan_create_dev()
> [PATCHv3 net-next 2/2] wwan: core: Unshadow error code returned by
> ida_alloc_range()
> 
> Or since the second patch is not depends on the first one and patches
> target different trees, patches could be submitted independently:
> 
> [PATCHv3 net] wwan: core: Avoid returning NULL from wwan_create_dev()
> [PATCHv3 net-next] wwan: core: Unshadow error code returned by ida_alloc_range()

Split and sent separately, thanks!

> 1. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-1-andriy.shevchenko@linux.intel.com/
> 2. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-2-andriy.shevchenko@linux.intel.com/

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-08-11 12:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  8:54 [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Andy Shevchenko
2021-08-06  8:54 ` [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range)) Andy Shevchenko
2021-08-06  9:17   ` Sergey Ryazanov
2021-08-06 14:19     ` Andy Shevchenko
2021-08-06 20:35       ` Sergey Ryazanov
2021-08-11 12:50         ` Andy Shevchenko [this message]
2021-08-06  9:32   ` Loic Poulain
2021-08-06  9:15 ` [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Sergey Ryazanov
2021-08-06  9:29 ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRPHlsmBv66r4+vD@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=ryazanov.s.a@gmail.com \
    --subject='Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).