Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrea Claudi <aclaudi@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, haliu@redhat.com
Subject: Re: [PATCH iproute2] lib: bpf_glue: remove useless assignment
Date: Thu, 12 Aug 2021 11:01:42 +0200	[thread overview]
Message-ID: <YRTjdoGzNBzLvCdn@renaissance-vector> (raw)
In-Reply-To: <20210811090815.0a6363db@hermes.local>

On Wed, Aug 11, 2021 at 09:08:15AM -0700, Stephen Hemminger wrote:
> It is bad style in C to do assignment in a conditional.
> It causes errors, and is not anymore efficient.
> 
I agree with you.

There is a large number of similar assignments in other parts of the
code; I can work on a treewide patch to address them all, if you think
it's a good idea.


  reply	other threads:[~2021-08-12  9:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07 16:58 Andrea Claudi
2021-08-11  3:00 ` Stephen Hemminger
2021-08-11  9:12   ` Andrea Claudi
2021-08-11 16:08     ` Stephen Hemminger
2021-08-12  9:01       ` Andrea Claudi [this message]
2021-08-12 16:26         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRTjdoGzNBzLvCdn@renaissance-vector \
    --to=aclaudi@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=haliu@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --subject='Re: [PATCH iproute2] lib: bpf_glue: remove useless assignment' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).