Netdev Archive on
help / color / mirror / Atom feed
From: Ido Schimmel <>
To: Vladimir Oltean <>
Cc:, Andrew Lunn <>,
	Vivien Didelot <>,
	Florian Fainelli <>
Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id
Date: Sun, 9 Jan 2022 19:25:38 +0200	[thread overview]
Message-ID: <YdsakgRku3ZgF77f@shredder> (raw)
In-Reply-To: <>

On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
> There are no legacy ports, DSA registers a devlink instance with ports
> unconditionally for all switch drivers. Therefore, delete the old-style
> ndo operations used for determining bridge forwarding domains.
> Signed-off-by: Vladimir Oltean <>

Looks correct to me.

If ndo_get_phys_port_name() is not implemented, then
devlink_compat_phys_port_name_get() is called which invokes
ndo_get_devlink_port() that you have implemented. Similarly, for

Reviewed-by: Ido Schimmel <>

  parent reply	other threads:[~2022-01-09 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 18:48 [RFC PATCH net-next 0/2] More aggressive DSA cleanup Vladimir Oltean
2022-01-07 18:48 ` [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id Vladimir Oltean
2022-01-07 19:37   ` Andrew Lunn
2022-01-07 19:48     ` Florian Fainelli
2022-01-07 20:00       ` Vladimir Oltean
2022-01-09 17:25   ` Ido Schimmel [this message]
2022-01-10  9:33     ` Jiri Pirko
2022-01-07 18:48 ` [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list Vladimir Oltean
2022-01-07 19:57   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdsakgRku3ZgF77f@shredder \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).