Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Ido Schimmel <idosch@idosch.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id
Date: Mon, 10 Jan 2022 10:33:57 +0100	[thread overview]
Message-ID: <Ydv9hZqDFVO4OhCt@nanopsycho> (raw)
In-Reply-To: <YdsakgRku3ZgF77f@shredder>

Sun, Jan 09, 2022 at 06:25:38PM CET, idosch@idosch.org wrote:
>On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
>> There are no legacy ports, DSA registers a devlink instance with ports
>> unconditionally for all switch drivers. Therefore, delete the old-style
>> ndo operations used for determining bridge forwarding domains.
>> 
>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
>Looks correct to me.

+1

>
>If ndo_get_phys_port_name() is not implemented, then
>devlink_compat_phys_port_name_get() is called which invokes
>ndo_get_devlink_port() that you have implemented. Similarly, for
>ndo_get_port_parent_id().
>
>Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  reply	other threads:[~2022-01-10  9:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 18:48 [RFC PATCH net-next 0/2] More aggressive DSA cleanup Vladimir Oltean
2022-01-07 18:48 ` [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id Vladimir Oltean
2022-01-07 19:37   ` Andrew Lunn
2022-01-07 19:48     ` Florian Fainelli
2022-01-07 20:00       ` Vladimir Oltean
2022-01-09 17:25   ` Ido Schimmel
2022-01-10  9:33     ` Jiri Pirko [this message]
2022-01-07 18:48 ` [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list Vladimir Oltean
2022-01-07 19:57   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ydv9hZqDFVO4OhCt@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@idosch.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    --subject='Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).