Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/net/usb: remove redundant status variable
@ 2022-01-10 10:44 cgel.zte
2022-01-10 10:55 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-01-10 10:44 UTC (permalink / raw)
To: davem
Cc: kuba, chi.minghao, andrew, grundler, oneukum, linux-usb, netdev,
linux-kernel, Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from sierra_net_send_cmd() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/net/usb/sierra_net.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
index bb4cbe8fc846..818ff8a24098 100644
--- a/drivers/net/usb/sierra_net.c
+++ b/drivers/net/usb/sierra_net.c
@@ -334,15 +334,12 @@ static int sierra_net_send_cmd(struct usbnet *dev,
static int sierra_net_send_sync(struct usbnet *dev)
{
- int status;
struct sierra_net_data *priv = sierra_net_get_private(dev);
dev_dbg(&dev->udev->dev, "%s", __func__);
- status = sierra_net_send_cmd(dev, priv->sync_msg,
+ return sierra_net_send_cmd(dev, priv->sync_msg,
sizeof(priv->sync_msg), "SYNC");
-
- return status;
}
static void sierra_net_set_ctx_index(struct sierra_net_data *priv, u8 ctx_ix)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/net/usb: remove redundant status variable
2022-01-10 10:44 [PATCH] drivers/net/usb: remove redundant status variable cgel.zte
@ 2022-01-10 10:55 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-01-10 10:55 UTC (permalink / raw)
To: cgel.zte
Cc: davem, kuba, chi.minghao, andrew, grundler, oneukum, linux-usb,
netdev, linux-kernel, Zeal Robot
On Mon, Jan 10, 2022 at 10:44:02AM +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from sierra_net_send_cmd() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
> drivers/net/usb/sierra_net.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
> index bb4cbe8fc846..818ff8a24098 100644
> --- a/drivers/net/usb/sierra_net.c
> +++ b/drivers/net/usb/sierra_net.c
> @@ -334,15 +334,12 @@ static int sierra_net_send_cmd(struct usbnet *dev,
>
> static int sierra_net_send_sync(struct usbnet *dev)
> {
> - int status;
> struct sierra_net_data *priv = sierra_net_get_private(dev);
>
> dev_dbg(&dev->udev->dev, "%s", __func__);
No need for this line anymore, and then, this whole function can be
removed as it would only be 1 line, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-10 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 10:44 [PATCH] drivers/net/usb: remove redundant status variable cgel.zte
2022-01-10 10:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).