Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
	andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
	zhengdejin5@gmail.com, richard.leitner@skidata.com,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support
Date: Tue, 1 Sep 2020 22:05:42 -0700	[thread overview]
Message-ID: <a4be65e9-64b6-81a0-4042-34cd024a137b@gmail.com> (raw)
In-Reply-To: <20200901082413.cjnmy3s4lb5pfhv5@pengutronix.de>



On 9/1/2020 1:24 AM, Marco Felsch wrote:
> Create :) Can you provide me a link? What I can say for now is: This
> solution was used by the micrel driver too and it seems to work. I
> wanted to keep the change smaller/more local because the current
> upstream state is: SMSC-Phy <-> FEC-Host ==> IRQ broken. If your patch
> fixes this too in a more general matter I'm fine with it and we can drop
> this patch but we should fix this as soon as possible.

Still working on it, I found a platform where there were some timing 
problems and am looking into it.

If your SMSC changes are so important and critical, get them applied to 
the "net" tree, your patch posting makes no mention of which netdev tree 
you are targeting.
-- 
Florian

  parent reply	other threads:[~2020-09-02  5:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 13:48 [PATCH 0/5] SMSC: Cleanups and clock setup Marco Felsch
2020-08-31 13:48 ` [PATCH 1/5] net: phy: smsc: skip ENERGYON interrupt if disabled Marco Felsch
2020-08-31 14:02   ` Andrew Lunn
2020-09-01  7:59     ` Marco Felsch
2020-08-31 13:48 ` [PATCH 2/5] net: phy: smsc: simplify config_init callback Marco Felsch
2020-08-31 13:48 ` [PATCH 3/5] dt-bindings: net: phy: smsc: document reference clock Marco Felsch
2020-08-31 13:48 ` [PATCH 4/5] net: phy: smsc: add phy refclk in support Marco Felsch
2020-08-31 14:08   ` Andrew Lunn
2020-09-01  8:04     ` Marco Felsch
2020-08-31 16:32   ` Florian Fainelli
2020-09-01  8:24     ` Marco Felsch
2020-09-01 12:30       ` Andrew Lunn
2020-09-02  5:05       ` Florian Fainelli [this message]
2020-08-31 13:48 ` [PATCH 5/5] net: phy: smsc: LAN8710/LAN8720: remove PHY_RST_AFTER_CLK_EN flag Marco Felsch
2020-08-31 14:11   ` Andrew Lunn
2020-09-01  8:01     ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4be65e9-64b6-81a0-4042-34cd024a137b@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.felsch@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=richard.leitner@skidata.com \
    --cc=robh+dt@kernel.org \
    --cc=zhengdejin5@gmail.com \
    --subject='Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).