Netdev Archive on
help / color / mirror / Atom feed
* [PATCH] can: flexcan: Fix an uninitialized variable issue
@ 2021-07-29 11:27 Christophe JAILLET
  2021-07-29 11:31 ` Marc Kleine-Budde
  0 siblings, 1 reply; 5+ messages in thread
From: Christophe JAILLET @ 2021-07-29 11:27 UTC (permalink / raw)
  To: wg, mkl, davem, kuba, angelo
  Cc: linux-can, netdev, linux-kernel, kernel-janitors, Christophe JAILLET

If both 'clk_ipg' and 'clk_per' are NULL, we return an un-init value.
So set 'err' to 0, to return success in such a case.

Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
Signed-off-by: Christophe JAILLET <>
Another way to fix it is to remove the NULL checks for 'clk_ipg' and
'clk_per' that been added in commit d9cead75b1c6.

They look useless to me because 'clk_prepare_enable()' returns 0 if it is
passed a NULL pointer.
Having these explicit tests is maybe informational (i.e. these pointers
can really be NULL) or have been added to silent a compiler or a static

So, in case, I've left the tests and just fixed the un-init 'err' variable
 drivers/net/can/flexcan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 54ffb796a320..7734229aa078 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
 static int flexcan_clks_enable(const struct flexcan_priv *priv)
-	int err;
+	int err = 0;
 	if (priv->clk_ipg) {
 		err = clk_prepare_enable(priv->clk_ipg);

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-29 12:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 11:27 [PATCH] can: flexcan: Fix an uninitialized variable issue Christophe JAILLET
2021-07-29 11:31 ` Marc Kleine-Budde
2021-07-29 11:44   ` Dan Carpenter
2021-07-29 11:57     ` Marc Kleine-Budde
2021-07-29 12:28       ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).