Netdev Archive on
help / color / mirror / Atom feed
To: "Matthieu Baerts" <>,,
Subject: Re: [PATCH net-next] net: Remove redundant if statements
Date: Fri, 06 Aug 2021 09:13:21 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

August 6, 2021 4:58 PM, "Matthieu Baerts" <> wrote:

> Hi Yajun,
> Thank you for sharing this patch.
> On 06/08/2021 08:38, Yajun Deng wrote:
>> The if statement already move into sock_{put , hold},
>> just remove it.
> I was wondering in which subtree you had 'sock_put' checking the socket
> pointer but then I realised you sent another patch just before adding
> this check: "net: sock: add the case if sk is NULL"
> Please next time send them in the same series to clearly indicate that
> this is the 2nd patch (2/2) and it depends on patch 1/2.
OK, Thank you for your advice.

> Related to the modification in MPTCP part: it looks OK but we do a few
> other calls to 'sock_put()' where we don't need to check if the socket
> is NULL or not.
> In other words, if your patch "net: sock: add the case if sk is NULL" is
> accepted, then the modification in "net/mptcp/subflow.c" is OK for us.
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions

  parent reply	other threads:[~2021-08-06  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  6:38 Yajun Deng
2021-08-06  8:58 ` Matthieu Baerts
2021-08-06  9:13 ` yajun.deng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-05 11:55 Yajun Deng
2021-08-05 12:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next] net: Remove redundant if statements' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).