From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A487C433E3 for ; Tue, 18 Aug 2020 19:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 832EE20789 for ; Tue, 18 Aug 2020 19:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgHRTDJ (ORCPT ); Tue, 18 Aug 2020 15:03:09 -0400 Received: from smtprelay0203.hostedemail.com ([216.40.44.203]:52818 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726435AbgHRTDI (ORCPT ); Tue, 18 Aug 2020 15:03:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 68C8C100E7B45; Tue, 18 Aug 2020 19:03:05 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ghost36_3e055b927021 X-Filterd-Recvd-Size: 3429 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Tue, 18 Aug 2020 19:03:03 +0000 (UTC) Message-ID: Subject: Re: [PATCH] qed_main: Remove unnecessary cast in kfree From: Joe Perches To: Jesse Brandeburg , Xu Wang Cc: aelior@marvell.com, GR-everest-linux-l2@marvell.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 18 Aug 2020 12:03:02 -0700 In-Reply-To: <20200818114403.00001257@intel.com> References: <20200818091056.12309-1-vulab@iscas.ac.cn> <20200818114403.00001257@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2020-08-18 at 11:44 -0700, Jesse Brandeburg wrote: > On Tue, 18 Aug 2020 09:10:56 +0000 > Xu Wang wrote: > > > Remove unnecassary casts in the argument to kfree. > > > > Signed-off-by: Xu Wang > > You seem to have several of these patches, they should be sent in a > series with the series patch subject (for example): > [PATCH net-next 0/n] fix up casts on kfree > > Did you use a coccinelle script to find these? > > They could all have Fixes tags. I'd resend the whole bunch as a series. > > Since this has no functional change, you could mention that in the > series commit message text. Commits with no functional change generally should not be marked with Fixes: And some wrapper functions might as well be removed and just kfree used in-place instead. Something like: --- drivers/net/ethernet/qlogic/qed/qed_main.c | 29 ++++++----------------------- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 2558cb680db3..961adb4d8910 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -482,24 +482,6 @@ int qed_fill_dev_info(struct qed_dev *cdev, return 0; } -static void qed_free_cdev(struct qed_dev *cdev) -{ - kfree((void *)cdev); -} - -static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev) -{ - struct qed_dev *cdev; - - cdev = kzalloc(sizeof(*cdev), GFP_KERNEL); - if (!cdev) - return cdev; - - qed_init_struct(cdev); - - return cdev; -} - /* Sets the requested power state */ static int qed_set_power_state(struct qed_dev *cdev, pci_power_t state) { @@ -618,9 +600,11 @@ static struct qed_dev *qed_probe(struct pci_dev *pdev, struct qed_dev *cdev; int rc; - cdev = qed_alloc_cdev(pdev); + cdev = kzalloc(sizeof(*cdev), GFP_KERNEL); if (!cdev) - goto err0; + return NULL; + + qed_init_struct(cdev); cdev->drv_type = DRV_ID_DRV_TYPE_LINUX; cdev->protocol = params->protocol; @@ -658,8 +642,7 @@ static struct qed_dev *qed_probe(struct pci_dev *pdev, err2: qed_free_pci(cdev); err1: - qed_free_cdev(cdev); -err0: + kfree(cdev); return NULL; } @@ -676,7 +659,7 @@ static void qed_remove(struct qed_dev *cdev) qed_devlink_unregister(cdev); - qed_free_cdev(cdev); + kfree(cdev); } static void qed_disable_msix(struct qed_dev *cdev)