Netdev Archive on
help / color / mirror / Atom feed
From: Florian Fainelli <>
To: Jakub Kicinski <>, Vladimir Oltean <>
Cc: Leon Romanovsky <>,
	Vladimir Oltean <>,, Andrew Lunn <>,
	Vivien Didelot <>
Subject: Re: [RFC PATCH net] net: dsa: tear down devlink port regions when tearing down the devlink port on error
Date: Tue, 7 Sep 2021 08:47:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/7/2021 8:44 AM, Jakub Kicinski wrote:
> On Sun, 5 Sep 2021 14:07:35 +0300 Vladimir Oltean wrote:
>> Again, fallback but not during devlink port register. The devlink port
>> was registered just fine, but our plans changed midway. If you want to
>> create a net device with an associated devlink port, first you need to
>> create the devlink port and then the net device, then you need to link
>> the two using devlink_port_type_eth_set, at least according to my
>> understanding.
>> So the failure is during the creation of the **net device**, we now have a
>> devlink port which was originally intended to be of the Ethernet type
>> and have a physical flavour, but it will not be backed by any net device,
>> because the creation of that just failed. So the question is simply what
>> to do with that devlink port.
> Is the failure you're referring to discovered inside the
> register_netdevice() call?

It is before, at the time we attempt to connect to the PHY device, prior 
to registering the netdev, we may fail that PHY connection, tearing down 
the entire switch because of that is highly undesirable.

Maybe we should re-order things a little bit and try to register devlink 
ports only after we successfully registered with the PHY/SFP and prior 
to registering the netdev?

  reply	other threads:[~2021-09-07 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 23:17 Vladimir Oltean
2021-09-05  7:07 ` Leon Romanovsky
2021-09-05  8:45   ` Vladimir Oltean
2021-09-05 10:25     ` Leon Romanovsky
2021-09-05 10:31       ` Vladimir Oltean
2021-09-05 10:47         ` Leon Romanovsky
2021-09-05 11:07           ` Vladimir Oltean
2021-09-05 13:01             ` Leon Romanovsky
2021-09-05 15:01               ` Vladimir Oltean
2021-09-07 15:44             ` Jakub Kicinski
2021-09-07 15:47               ` Florian Fainelli [this message]
2021-09-07 16:43                 ` Andrew Lunn
2021-09-07 16:49                   ` Florian Fainelli
2021-09-07 22:59                     ` Leon Romanovsky
2021-09-08 20:21                     ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH net] net: dsa: tear down devlink port regions when tearing down the devlink port on error' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).