Netdev Archive on
help / color / mirror / Atom feed
From: Jie Luo <>
To: Andrew Lunn <>
Subject: Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO
Date: Mon, 9 Aug 2021 21:06:43 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <YQ/>

On 8/8/2021 11:47 PM, Andrew Lunn wrote:
> On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
>> The new added properties resource "reg" is for configuring
>> ethernet LDO in the IPQ5018 chipset, the property "clocks"
>> is for configuring the MDIO clock source frequency.
>> This patch depends on the following patch:
>> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
>> driver")
> Please always make binding patches part of the series containing the
> driver code. We sometimes need to see both to do a proper review.
> Add a comment about when the second address range and clock is
> required. Does qcom,ipq5018-mdio require them?
> 	  Andrew

Hi Andrew,

yes, the second address range is only required for qcom,ipq5018-mdio 

will document it in next patch set, and send it with the drive code 
patch, thanks

for the comments and review.

      reply	other threads:[~2021-08-09 13:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  7:53 Luo Jie
2021-08-08 15:47 ` Andrew Lunn
2021-08-09 13:06   ` Jie Luo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).