Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Florian Westphal <fw@strlen.de>,
Aaron Conole <aconole@redhat.com>,
Numan Siddique <nusiddiq@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Pravin B Shelar <pshelar@ovn.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Lourdes Pedrajas <lu@pplo.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] selftests: pmtu.sh: Add tests for bridged UDP tunnels
Date: Tue, 4 Aug 2020 08:00:19 -0600 [thread overview]
Message-ID: <baf285cf-5f58-e36d-abf9-32a8414bada7@gmail.com> (raw)
In-Reply-To: <6b2a52ca59d791dfd5547acb62e710e61e646588.1596520062.git.sbrivio@redhat.com>
On 8/3/20 11:53 PM, Stefano Brivio wrote:
> @@ -497,12 +529,19 @@ setup_vxlan_or_geneve() {
> run_cmd ${ns_a} ip link add ${type}_a type ${type} id 1 ${opts_a} remote ${b_addr} ${opts} || return 1
> run_cmd ${ns_b} ip link add ${type}_b type ${type} id 1 ${opts_b} remote ${a_addr} ${opts}
>
> - run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${type}_a
> - run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b
> + if [ -n "${br_if_a}" ]; then
> + run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${br_if_a}
> + run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${br_if_a}
> + run_cmd ${ns_a} ip link set ${type}_a master ${br_if_a}
> + else
> + run_cmd ${ns_a} ip addr add ${tunnel4_a_addr}/${tunnel4_mask} dev ${type}_a
> + run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${type}_a
> + fi
>
> - run_cmd ${ns_a} ip addr add ${tunnel6_a_addr}/${tunnel6_mask} dev ${type}_a
> + run_cmd ${ns_b} ip addr add ${tunnel4_b_addr}/${tunnel4_mask} dev ${type}_b
> run_cmd ${ns_b} ip addr add ${tunnel6_b_addr}/${tunnel6_mask} dev ${type}_b
>
> +
extra newline snuck in
other than that:
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-08-04 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 5:53 [PATCH net-next v2 0/6] Support PMTU discovery with " Stefano Brivio
2020-08-04 5:53 ` [PATCH net-next v2 1/6] ipv4: route: Ignore output interface in FIB lookup for PMTU route Stefano Brivio
2020-08-04 13:54 ` David Ahern
2020-08-04 5:53 ` [PATCH net-next v2 2/6] tunnels: PMTU discovery support for directly bridged IP packets Stefano Brivio
2020-08-04 13:54 ` David Ahern
2020-08-05 16:54 ` Naresh Kamboju
2020-08-05 17:02 ` Stefano Brivio
2020-08-04 5:53 ` [PATCH net-next v2 3/6] vxlan: Support for PMTU discovery on directly bridged links Stefano Brivio
2020-08-04 5:53 ` [PATCH net-next v2 4/6] geneve: " Stefano Brivio
2020-08-04 5:53 ` [PATCH net-next v2 5/6] selftests: pmtu.sh: Add tests for bridged UDP tunnels Stefano Brivio
2020-08-04 14:00 ` David Ahern [this message]
2020-08-04 14:35 ` Stefano Brivio
2020-08-04 5:53 ` [PATCH net-next v2 6/6] selftests: pmtu.sh: Add tests for UDP tunnels handled by Open vSwitch Stefano Brivio
2020-08-04 20:02 ` [PATCH net-next v2 0/6] Support PMTU discovery with bridged UDP tunnels David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf285cf-5f58-e36d-abf9-32a8414bada7@gmail.com \
--to=dsahern@gmail.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=lu@pplo.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nusiddiq@redhat.com \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
--cc=sbrivio@redhat.com \
--subject='Re: [PATCH net-next v2 5/6] selftests: pmtu.sh: Add tests for bridged UDP tunnels' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).