Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>, dsahern@gmail.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2 net-next v2] iplink: add support for protodown reason
Date: Tue, 1 Sep 2020 19:54:53 -0600	[thread overview]
Message-ID: <bbb1ce0c-c5e5-bdfd-57e4-80e6ccf6d3b3@gmail.com> (raw)
In-Reply-To: <20200829034256.47225-1-roopa@cumulusnetworks.com>

On 8/28/20 9:42 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> This patch adds support for recently
> added link IFLA_PROTO_DOWN_REASON attribute.
> IFLA_PROTO_DOWN_REASON enumerates reasons
> for the already existing IFLA_PROTO_DOWN link
> attribute.
> 
> $ cat /etc/iproute2/protodown_reasons.d/r.conf
> 0 mlag
> 1 evpn
> 2 vrrp
> 3 psecurity
> 

none of these are standardized right? Or perhaps they are through FRR?

Would be worth mentioning in the man page that the reasons are localized
if so.

> 
> Note: for somereason the json and non-json key for protodown
> are different (protodown and proto_down). I have kept the
> same for protodown reason for consistency (protodown_reason and
> proto_down_reason).
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> v2 - address comments from David Ahern
> 

applied to iproute2-next. Thanks



  reply	other threads:[~2020-09-02  1:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  3:42 [PATCH iproute2 net-next v2] iplink: add support for protodown reason Roopa Prabhu
2020-09-02  1:54 ` David Ahern [this message]
2020-09-07  6:04   ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbb1ce0c-c5e5-bdfd-57e4-80e6ccf6d3b3@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).