Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, davem@davemloft.net,
lorenzo.bianconi@redhat.com, brouer@redhat.com,
echaudro@redhat.com, sameehj@amazon.com, kuba@kernel.org
Subject: [PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame
Date: Wed, 19 Aug 2020 15:13:46 +0200 [thread overview]
Message-ID: <c2665f369ede07328bbf7456def2e2025b9b320e.1597842004.git.lorenzo@kernel.org> (raw)
In-Reply-To: <cover.1597842004.git.lorenzo@kernel.org>
Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer to specify
if shared_info area has been properly initialized for non-linear
xdp buffers
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
include/net/xdp.h | 8 ++++++--
net/core/xdp.c | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/net/xdp.h b/include/net/xdp.h
index 3814fb631d52..42f439f9fcda 100644
--- a/include/net/xdp.h
+++ b/include/net/xdp.h
@@ -72,7 +72,8 @@ struct xdp_buff {
void *data_hard_start;
struct xdp_rxq_info *rxq;
struct xdp_txq_info *txq;
- u32 frame_sz; /* frame size to deduce data_hard_end/reserved tailroom*/
+ u32 frame_sz:31; /* frame size to deduce data_hard_end/reserved tailroom*/
+ u32 mb:1; /* xdp non-linear buffer */
};
/* Reserve memory area at end-of data area.
@@ -96,7 +97,8 @@ struct xdp_frame {
u16 len;
u16 headroom;
u32 metasize:8;
- u32 frame_sz:24;
+ u32 frame_sz:23;
+ u32 mb:1; /* xdp non-linear frame */
/* Lifetime of xdp_rxq_info is limited to NAPI/enqueue time,
* while mem info is valid on remote CPU.
*/
@@ -141,6 +143,7 @@ void xdp_convert_frame_to_buff(struct xdp_frame *frame, struct xdp_buff *xdp)
xdp->data_end = frame->data + frame->len;
xdp->data_meta = frame->data - frame->metasize;
xdp->frame_sz = frame->frame_sz;
+ xdp->mb = frame->mb;
}
static inline
@@ -167,6 +170,7 @@ int xdp_update_frame_from_buff(struct xdp_buff *xdp,
xdp_frame->headroom = headroom - sizeof(*xdp_frame);
xdp_frame->metasize = metasize;
xdp_frame->frame_sz = xdp->frame_sz;
+ xdp_frame->mb = xdp->mb;
return 0;
}
diff --git a/net/core/xdp.c b/net/core/xdp.c
index 48aba933a5a8..884f140fc3be 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -454,6 +454,7 @@ struct xdp_frame *xdp_convert_zc_to_xdp_frame(struct xdp_buff *xdp)
xdpf->headroom = 0;
xdpf->metasize = metasize;
xdpf->frame_sz = PAGE_SIZE;
+ xdpf->mb = xdp->mb;
xdpf->mem.type = MEM_TYPE_PAGE_ORDER0;
xsk_buff_free(xdp);
--
2.26.2
next prev parent reply other threads:[~2020-08-19 13:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 13:13 [PATCH net-next 0/6] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2020-08-19 13:13 ` Lorenzo Bianconi [this message]
2020-08-23 14:08 ` [PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame Shay Agroskin
2020-08-24 8:44 ` Jesper Dangaard Brouer
2020-08-26 9:47 ` Shay Agroskin
2020-08-19 13:13 ` [PATCH net-next 2/6] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers Lorenzo Bianconi
2020-08-19 13:13 ` [PATCH net-next 3/6] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2020-08-20 8:02 ` Jesper Dangaard Brouer
2020-08-20 8:11 ` Lorenzo Bianconi
2020-08-20 19:38 ` Maciej Fijalkowski
2020-08-21 7:43 ` Lorenzo Bianconi
2020-08-19 13:13 ` [PATCH net-next 4/6] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2020-08-20 7:52 ` Jesper Dangaard Brouer
2020-08-20 7:56 ` Lorenzo Bianconi
2020-08-19 13:13 ` [PATCH net-next 5/6] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2020-08-19 13:13 ` [PATCH net-next 6/6] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2020-08-19 19:23 ` Jakub Kicinski
2020-08-19 20:22 ` Lorenzo Bianconi
2020-08-19 21:14 ` Jakub Kicinski
2020-08-19 21:58 ` John Fastabend
2020-08-20 7:47 ` Jesper Dangaard Brouer
2020-08-20 7:54 ` Lorenzo Bianconi
2020-08-20 13:16 ` [PATCH net-next 0/6] mvneta: introduce XDP multi-buffer support Jesper Dangaard Brouer
2020-08-20 13:36 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2665f369ede07328bbf7456def2e2025b9b320e.1597842004.git.lorenzo@kernel.org \
--to=lorenzo@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sameehj@amazon.com \
--subject='Re: [PATCH net-next 1/6] xdp: introduce mb in xdp_buff/xdp_frame' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).