From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B18C4338F for ; Mon, 9 Aug 2021 22:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28B1D604DC for ; Mon, 9 Aug 2021 22:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236727AbhHIWa7 (ORCPT ); Mon, 9 Aug 2021 18:30:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51440 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbhHIWa6 (ORCPT ); Mon, 9 Aug 2021 18:30:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628548236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BjH3lVoue/JL4btoApF2k0x+vF5e5YSb7pGpRSYghz4=; b=S4Z9kfVRVKSrl58elQHd88VMjyS448HjrxXXSeitZg8Z7R0cd2WmNamwFQgQd0JnfjkPSY R04IsLlwaKNM1hLJpPNP49B31IzVE2wdkzgTkVcXZOM/lsGLpMGuuW2Ul6fOXj3TRecM2Y DylNkmBCSvgEQ11HFDtug3UoTEjXCZQ= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-zkvRKcIWPImOgePQZZ8REw-1; Mon, 09 Aug 2021 18:30:35 -0400 X-MC-Unique: zkvRKcIWPImOgePQZZ8REw-1 Received: by mail-qk1-f200.google.com with SMTP id q11-20020a05620a05abb02903ca17a8eef8so10780464qkq.10 for ; Mon, 09 Aug 2021 15:30:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BjH3lVoue/JL4btoApF2k0x+vF5e5YSb7pGpRSYghz4=; b=Qt9kCtwU+62l0/E9BJZURiXBeOA8LfiybX6DM9ZBAvSgznANt+qtML+H4+2HCfDcEj 6k6WRNBM+nzqH2/lXtM2Mv17hdaxchCMNa8zeX0LKa9PZxQKCZEaDIf8Hc5pv/wbVzRj 0TLVbthBHUTdvDRArXllfX9CE4oLTw2D8P/KdtvTvkQ6AdVwXdY6Zc7VDBqHtDfcPDIx L9/C7FI0dyS/MWkulQtnDN4yVRXKg3BlEFpZEbd3twzLvGMNsTZvBz3rPeH4n6Ew7Ajp WSkgHzz7/ztvrGYR5wgpB9sI5ghYo1TdK2j1ScMHk90sgoJ1Kkvt8Wpztu8FFrFriH9f q8kQ== X-Gm-Message-State: AOAM530shK7GvwdkXRP/q1pBCmYxlhvY1BdYN8/DCBnlIiaPvbhGh5XY rUo3VKCiYssmv4odGR9VHgSPxBquJsQJqy7Mg2uhH4v110AdxL+YZhAPgVSWHss/JtbhHAxI7GJ miLN4ixhGlWm7nYBj X-Received: by 2002:ad4:5f09:: with SMTP id fo9mr14663288qvb.35.1628548235172; Mon, 09 Aug 2021 15:30:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys63neYYC0CsWGSSBTnSkVTM1U47S3lEOoT7cddDJABMx3HwrVAydq7pk663/OgQKN+d7p4Q== X-Received: by 2002:ad4:5f09:: with SMTP id fo9mr14663273qvb.35.1628548234963; Mon, 09 Aug 2021 15:30:34 -0700 (PDT) Received: from jtoppins.rdu.csb ([107.15.110.69]) by smtp.gmail.com with ESMTPSA id v19sm5439662qta.60.2021.08.09.15.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 15:30:34 -0700 (PDT) Subject: Re: [PATCH] netlink: NL_SET_ERR_MSG - remove local static array To: Joe Perches , netdev Cc: Johannes Berg , LKML References: <1f99c69f4e640accaf7459065e6625e73ec0f8d4.camel@perches.com> From: Jonathan Toppins Message-ID: Date: Mon, 9 Aug 2021 18:30:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1f99c69f4e640accaf7459065e6625e73ec0f8d4.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/9/21 1:04 PM, Joe Perches wrote: > The want was to have some separate object section for netlink messages > so all netlink messages could be specifically listed by some tool but > the effect is duplicating static const char arrays in the object code. > > It seems unused presently so change the macro to avoid the local static > declarations until such time as these actually are wanted and used. > > This reduces object size ~8KB in an x86-64 defconfig without modules. > > $ size vmlinux.o* > text data bss dec hex filename > 20110471 3460344 741760 24312575 172faff vmlinux.o.new > 20119444 3460344 741760 24321548 1731e0c vmlinux.o.old > > Signed-off-by: Joe Perches Seems reasonable. Acked-by: Jonathan Toppins