Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: ast@kernel.org, andrii@kernel.org, kafai@fb.com,
	songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, quentin@isovalent.com, toke@redhat.com,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 0/3] tools: ksnoop: tracing kernel function entry/return with argument/return value display
Date: Fri, 6 Aug 2021 16:56:14 +0200	[thread overview]
Message-ID: <c854434c-20ba-b181-9bed-9cf289030e12@iogearbox.net> (raw)
In-Reply-To: <alpine.LRH.2.23.451.2108051210470.19742@localhost>

On 8/5/21 1:14 PM, Alan Maguire wrote:
> On Wed, 4 Aug 2021, Daniel Borkmann wrote:
>> On 8/3/21 11:23 PM, Alan Maguire wrote:
>>> Recent functionality added to libbpf [1] enables typed display of kernel
>>> data structures; here that functionality is exploited to provide a
>>> simple example of how a tracer can support deep argument/return value
>>> inspection.  The intent is to provide a demonstration of these features
>>> to help facilitate tracer adoption, while also providing a tool which
>>> can be useful for kernel debugging.
>>
>> Thanks a lot for working on this tool, this looks _super useful_! Right now
>> under tools/bpf/ we have bpftool and resolve_btfids as the two main tools,
>> the latter used during kernel build, and the former evolving with the kernel
>> together with libbpf. The runqslower in there was originally thought of as
>> a single/small example tool to demo how to build stand-alone tracing tools
>> with all the modern practices, though the latter has also been added to [0]
>> (thus could be removed). I would rather love if you could add ksnoop for
>> inclusion into bcc's libbpf-based tracing tooling suite under [0] as well
>> which would be a better fit long term rather than kernel tree for the tool
>> to evolve. We don't intend to add a stand-alone tooling collection under the
>> tools/bpf/ long term since these can evolve better outside of kernel tree.
> 
> Sounds good; I'll look into contributing the tool to bcc.

Awesome, thanks a lot Alan!

      reply	other threads:[~2021-08-06 14:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 21:23 Alan Maguire
2021-08-03 21:23 ` [PATCH bpf-next 1/3] tools: ksnoop: kernel argument/return value tracing/display using BTF Alan Maguire
2021-08-03 21:23 ` [PATCH bpf-next 2/3] tools: ksnoop: document ksnoop tracing of entry/return with value display Alan Maguire
2021-08-03 21:23 ` [PATCH bpf-next 3/3] tools: ksnoop: add .gitignore Alan Maguire
2021-08-04 21:05 ` [PATCH bpf-next 0/3] tools: ksnoop: tracing kernel function entry/return with argument/return value display Daniel Borkmann
2021-08-05 11:14   ` Alan Maguire
2021-08-06 14:56     ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c854434c-20ba-b181-9bed-9cf289030e12@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quentin@isovalent.com \
    --cc=songliubraving@fb.com \
    --cc=toke@redhat.com \
    --cc=yhs@fb.com \
    --subject='Re: [PATCH bpf-next 0/3] tools: ksnoop: tracing kernel function entry/return with argument/return value display' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).