Netdev Archive on
help / color / mirror / Atom feed
From: Florian Fainelli <>
To: Vladimir Oltean <>,, Jakub Kicinski <>,
	"David S. Miller" <>
Cc: Andrew Lunn <>,
	Vivien Didelot <>,
	Sean Wang <>,
	Landen Chao <>,
	DENG Qingfang <>
Subject: Re: [PATCH net-next] net: dsa: mt7530: drop paranoid checks in .get_tag_protocol()
Date: Fri, 30 Jul 2021 20:08:43 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 7/30/2021 3:57 PM, Vladimir Oltean wrote:
> It is desirable to reduce the surface of DSA_TAG_PROTO_NONE as much as
> we can, because we now have options for switches without hardware
> support for DSA tagging, and the occurrence in the mt7530 driver is in
> fact quite gratuitout and easy to remove. Since ds->ops->get_tag_protocol()
> is only called for CPU ports, the checks for a CPU port in
> mtk_get_tag_protocol() are redundant and can be removed.

The point of the check was in case the designated CPU port from device 
tree/platform data would not match what the Mediatek driver supports, 
similar to what b53 does in the same vein. I am fine with removing that 
check for mt7530 as it does not look like there is an use case where the 
CPU port is not actually MT7530_CPU_PORT.

Reviewed-by: Florian Fainelli <>

  parent reply	other threads:[~2021-07-31  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 22:57 Vladimir Oltean
2021-07-31  2:54 ` DENG Qingfang
2021-07-31  3:08 ` Florian Fainelli [this message]
2021-07-31 14:08   ` Vladimir Oltean
2021-08-02 14:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next] net: dsa: mt7530: drop paranoid checks in .get_tag_protocol()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).