From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881BAC433E1 for ; Mon, 24 Aug 2020 11:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56279206BE for ; Mon, 24 Aug 2020 11:10:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="H1F4z49n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgHXLKY (ORCPT ); Mon, 24 Aug 2020 07:10:24 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:33394 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgHXLKL (ORCPT ); Mon, 24 Aug 2020 07:10:11 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07OBA3cp096925; Mon, 24 Aug 2020 06:10:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1598267403; bh=vhy+lFcf4NUB3k3T2KW/aXZiD6OvvZfTixhkehOLtTA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=H1F4z49nnK9dEeMvoVHhvqYeZV1x8jGX3yEkDuHI6d7LZ9J0fEARLurnXDq9NiQwg 2/St8hc4mwojV+u5K56mpCqkvxzLQmhvdoMTM1qPMpq4oIvl6xE+WzVr/9ee6/YcrH 7+ak6NDIHMLY7m+vhnxNRVY2aLMfFF/DSed87nJM= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 07OBA3UX020603 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Aug 2020 06:10:03 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 24 Aug 2020 06:10:03 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 24 Aug 2020 06:10:03 -0500 Received: from [10.250.53.226] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07OBA2CF027716; Mon, 24 Aug 2020 06:10:03 -0500 Subject: Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port To: Jesse Brandeburg CC: , , , , , , References: <20200821134912.30008-1-m-karicheri2@ti.com> <20200821134912.30008-2-m-karicheri2@ti.com> <20200821130002.00002367@intel.com> From: Murali Karicheri Message-ID: Date: Mon, 24 Aug 2020 07:09:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200821130002.00002367@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/21/20 4:00 PM, Jesse Brandeburg wrote: > Murali Karicheri wrote: > >> To flush the vid + mc entries from ALE, which is required when a VLAN >> interface is removed, driver needs to call cpsw_ale_flush_multicast() >> with ALE_PORT_HOST for port mask as these entries are added only for >> host port. Without this, these entries remain in the ALE table even >> after removing the VLAN interface. cpsw_ale_flush_multicast() calls >> cpsw_ale_flush_mcast which expects a port mask to do the job. >> >> Signed-off-by: Murali Karicheri > > Patch looks good but please resend with a Fixes: tag. > Sure will do -- Murali Karicheri Texas Instruments