Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] atm: horizon: Fix spelling mistakes in TX comment
@ 2021-08-07 12:49 Jun Miao
2021-08-07 13:21 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Jun Miao @ 2021-08-07 12:49 UTC (permalink / raw)
To: 3chas3; +Cc: linux-atm-general, netdev, linux-kernel, jun.miao
It's "mustn't", not "musn't", meaning "shall not".
Let's fix that.
Signed-off-by: Jun Miao <jun.miao@windriver.com>
---
drivers/atm/horizon.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 4f2951cbe69c..9ee494bc5c51 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
// Part of the job is done by atm_pcr_goal which gives us a PCR
// specification which says: EITHER grab the maximum available PCR
- // (and perhaps a lower bound which we musn't pass), OR grab this
+ // (and perhaps a lower bound which we mustn't pass), OR grab this
// amount, rounding down if you have to (and perhaps a lower bound
- // which we musn't pass) OR grab this amount, rounding up if you
- // have to (and perhaps an upper bound which we musn't pass). If any
+ // which we mustn't pass) OR grab this amount, rounding up if you
+ // have to (and perhaps an upper bound which we mustn't pass). If any
// bounds ARE passed we fail. Note that rounding is only rounding to
// match device limitations, we do not round down to satisfy
// bandwidth availability even if this would not violate any given
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: horizon: Fix spelling mistakes in TX comment
2021-08-07 12:49 [PATCH] atm: horizon: Fix spelling mistakes in TX comment Jun Miao
@ 2021-08-07 13:21 ` Joe Perches
2021-08-07 13:57 ` Jun Miao
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2021-08-07 13:21 UTC (permalink / raw)
To: Jun Miao, 3chas3; +Cc: linux-atm-general, netdev, linux-kernel
On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote:
> It's "mustn't", not "musn't", meaning "shall not".
> Let's fix that.
Perhaps more useful to change to 'must not' for the
non-native speaker.
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
[]
> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
>
>
> // Part of the job is done by atm_pcr_goal which gives us a PCR
> // specification which says: EITHER grab the maximum available PCR
> - // (and perhaps a lower bound which we musn't pass), OR grab this
> + // (and perhaps a lower bound which we mustn't pass), OR grab this
> // amount, rounding down if you have to (and perhaps a lower bound
> - // which we musn't pass) OR grab this amount, rounding up if you
> - // have to (and perhaps an upper bound which we musn't pass). If any
> + // which we mustn't pass) OR grab this amount, rounding up if you
> + // have to (and perhaps an upper bound which we mustn't pass). If any
> // bounds ARE passed we fail. Note that rounding is only rounding to
> // match device limitations, we do not round down to satisfy
> // bandwidth availability even if this would not violate any given
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: horizon: Fix spelling mistakes in TX comment
2021-08-07 13:21 ` Joe Perches
@ 2021-08-07 13:57 ` Jun Miao
0 siblings, 0 replies; 3+ messages in thread
From: Jun Miao @ 2021-08-07 13:57 UTC (permalink / raw)
To: Joe Perches, 3chas3; +Cc: linux-atm-general, netdev, linux-kernel
On 8/7/21 9:21 PM, Joe Perches wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote:
>> It's "mustn't", not "musn't", meaning "shall not".
>> Let's fix that.
> Perhaps more useful to change to 'must not' for the
> non-native speaker.
Ok, V2 : Suggested-by: Joe Perches <joe@perches.com>
Thanks
Jun
>> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> []
What's mean this [] ?
>> @@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
>>
>>
>> // Part of the job is done by atm_pcr_goal which gives us a PCR
>> // specification which says: EITHER grab the maximum available PCR
>> - // (and perhaps a lower bound which we musn't pass), OR grab this
>> + // (and perhaps a lower bound which we mustn't pass), OR grab this
>> // amount, rounding down if you have to (and perhaps a lower bound
>> - // which we musn't pass) OR grab this amount, rounding up if you
>> - // have to (and perhaps an upper bound which we musn't pass). If any
>> + // which we mustn't pass) OR grab this amount, rounding up if you
>> + // have to (and perhaps an upper bound which we mustn't pass). If any
>> // bounds ARE passed we fail. Note that rounding is only rounding to
>> // match device limitations, we do not round down to satisfy
>> // bandwidth availability even if this would not violate any given
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-07 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-07 12:49 [PATCH] atm: horizon: Fix spelling mistakes in TX comment Jun Miao
2021-08-07 13:21 ` Joe Perches
2021-08-07 13:57 ` Jun Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).