Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Gerhard Engleder <gerhard@engleder-embedded.com>,
	Michal Simek <michal.simek@xilinx.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] arm64: dts: zynqmp: Add ZCU104 based TSN endpoint
Date: Thu, 29 Jul 2021 07:22:41 +0200	[thread overview]
Message-ID: <d763d777-f258-7390-a85a-6cae098102eb@xilinx.com> (raw)
In-Reply-To: <CANr-f5xJbTYa-jPzVMPcAV2Un+POBn24gd+604rzPt36RkRcDQ@mail.gmail.com>



On 7/28/21 10:51 PM, Gerhard Engleder wrote:
> On Wed, Jul 28, 2021 at 12:59 PM Michal Simek <michal.simek@xilinx.com> wrote:
>>>> In past we said that we won't be accepting any FPGA description in
>>>> u-boot/linux projects. I don't think anything has changed from that time
>>>> and I don't want to end up in situation that we will have a lot of
>>>> configurations which none else can try and use.
>> You have to share to customers bitstream. Likely also boot.bin with
>> PS/PL configuration and other files in it. That's why it will be quite
>> simple to also share them full DT or DT overlay just for your IP in the
>> same image.
> 
> That's possible of course.
> 
>> Till now I didn't hear any strong argument why this should be accepted.
> 
> I want to try a new argument:
> 
> For new bindings a schema is used. The goal is to ensure that the binding
> schema and the driver fit together. The validation chain is the following:
> 1) The binding schema is used to validate the device tree.
> 2) The device tree is used to "validate" the driver by booting.
> 
> So the kernel tree needs to contain a device tree which uses the binding
> to build up the complete validation chain. The validation of the driver against
> the binding is not possible without a device tree. The only option would be
> to compare driver and binding manually, which is error prone.
> 
> If device trees with FPGA descriptions are not allowed in the kernel tree, then
> the kernel tree will never contain complete validation chains für FPGA based
> IPs. The validation of bindings for FPGA based IPs has to rely on device trees
> which are maintained out of tree. It is possible/likely that schema
> validation is
> not done out of tree. As a result it is more likely that binding and
> driver do not
> fit together for FPGA based IPs. In the end the quality of the support for FPGA
> based IPs would suffer.
> 
> I suggest allowing a single device tree with FPGA descriptions for a binding
> of FPGA based IPs. This will build up the complete validation chain in the
> kernel tree and ensures that binding and driver fit together. This single device
> tree would form the reference platform for the FPGA based IP.

This is good theory but the only person who can do this validation is
you or your customer who is interested in TSN. I am doing this for quite
a long time and even people are giving me commitments that they will
support the whole custom board but they stop to do at some point and
then silently disappear. Then it is up to me to deal with this and I
really don't want to do it.
When your driver is merged you should start to do regression testing
against linux-next, rc versions. When you convince me that you are
regularly doing this for 2 years or so we can restart this discussion.

Till that time you can simply keep rebasing one patch with your DT on
the top which is quite easy to do and you get all
functionality/advantages you are asking about above.

Thanks,
Michal



  reply	other threads:[~2021-07-29  5:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 19:45 [PATCH net-next 0/5] TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-07-26 19:45 ` [PATCH net-next 1/5] dt-bindings: Add vendor prefix for Engleder Gerhard Engleder
2021-07-26 19:46 ` [PATCH net-next 2/5] dt-bindings: net: Add tsnep Ethernet controller Gerhard Engleder
2021-07-26 23:35   ` Rob Herring
2021-07-27 18:34     ` Gerhard Engleder
2021-07-27 20:25       ` Rob Herring
2021-07-27 20:33         ` Gerhard Engleder
2021-07-28  5:13         ` Michal Simek
2021-07-28  7:44           ` Gerhard Engleder
2021-07-28 10:55             ` Michal Simek
2021-07-28 20:14               ` Gerhard Engleder
2021-07-29  5:07                 ` Michal Simek
2021-07-29  7:07                   ` Gerhard Engleder
2021-07-29  7:57                     ` Michal Simek
2021-07-26 19:46 ` [PATCH net-next 3/5] dt-bindings: arm: Add Engleder bindings Gerhard Engleder
2021-07-26 19:46 ` [PATCH net-next 4/5] tsnep: Add TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-07-26 20:49   ` Andrew Lunn
2021-07-27 20:18     ` Gerhard Engleder
2021-07-26 21:15   ` Andrew Lunn
2021-07-27 20:49     ` Gerhard Engleder
2021-07-26 21:29   ` Andrew Lunn
2021-07-27 22:05     ` Gerhard Engleder
2021-07-27 22:41       ` Andrew Lunn
2021-07-28  8:24         ` Gerhard Engleder
2021-07-26 23:25   ` kernel test robot
2021-07-26 19:46 ` [PATCH net-next 5/5] arm64: dts: zynqmp: Add ZCU104 based TSN endpoint Gerhard Engleder
2021-07-26 23:40   ` Rob Herring
2021-07-27 20:10     ` Gerhard Engleder
2021-07-27 20:17       ` Rob Herring
2021-07-27 20:23         ` Gerhard Engleder
2021-07-28  5:10           ` Michal Simek
2021-07-28  8:19             ` Gerhard Engleder
2021-07-28 10:58               ` Michal Simek
2021-07-28 20:51                 ` Gerhard Engleder
2021-07-29  5:22                   ` Michal Simek [this message]
2021-07-29  6:47                     ` Gerhard Engleder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d763d777-f258-7390-a85a-6cae098102eb@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gerhard@engleder-embedded.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH net-next 5/5] arm64: dts: zynqmp: Add ZCU104 based TSN endpoint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).