Netdev Archive on
help / color / mirror / Atom feed
From: Jason Wang <>
To: "Michael S. Tsirkin" <>
Cc: Jakub Kicinski <>,,,,,,,,
Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO
Date: Thu, 12 Aug 2021 14:18:21 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

在 2021/8/12 下午12:50, Michael S. Tsirkin 写道:
> On Thu, Aug 12, 2021 at 11:23:04AM +0800, Jason Wang wrote:
>> 在 2021/8/12 上午6:17, Jakub Kicinski 写道:
>>> On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote:
>>>> Try to fix this by using NETIF_F_GRO_HW instead so we're not
>>>> guaranteed to be re-segmented as original.
>>> This sentence may need rephrasing.
>> Right, actually, I meant:
>> Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the
>> packet could be re-segmented to the exact original packet stream. Since it's
>> really depends on the bakcend implementation.
>>>> Or we may want a new netdev
>>>> feature like RX_GSO since the guest offloads for virtio-net is
>>>> actually to receive GSO packet.
>>>> Or we can try not advertise LRO is control guest offloads is not
>>>> enabled. This solves the warning but will still slow down the traffic.
>>> IMO gro-hw fits pretty well, patch looks good.
>> If the re-segmentation is not a issue. I will post a formal patch.
>> Thanks
> It is but the point is even though spec did not require this
> we always allowed these configurations
> in the past so hopefully most of them are not broken and combine
> packets in the same way as GRO. Let's not break them all
> in an attempt to catch bad configs, and meanwhile amend
> the spec to recommend doing GW GRO.

Ok, let me add this in the commit log and send a formal patch.



  reply	other threads:[~2021-08-12  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  8:16 Jason Wang
2021-08-11 22:17 ` Jakub Kicinski
2021-08-12  3:23   ` Jason Wang
2021-08-12  4:50     ` Michael S. Tsirkin
2021-08-12  6:18       ` Jason Wang [this message]
2021-08-12  1:20 ` ivan
2021-08-12  4:59   ` Michael S. Tsirkin
2021-08-12  6:28     ` ivan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).