Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: VLAN over HSR/PRP - Issue with rx_handler not called for VLAN hw acceleration
Date: Wed, 19 Aug 2020 12:08:21 -0400	[thread overview]
Message-ID: <dcea193d-8143-a664-947c-8a1baea7bc2c@ti.com> (raw)

All,

I am working to add VLAN interface creation over HSR/PRP interface.
It works fine after I fixed the HSR driver to allow creation of
VLAN over it and with VLAN without hw acceleration. But with hw
acceleration, the HSR hook is bypassed in net/core/dev.c as

	if (skb_vlan_tag_present(skb)) {
		if (pt_prev) {
			ret = deliver_skb(skb, pt_prev, orig_dev);
			pt_prev = NULL;
		}
		if (vlan_do_receive(&skb))
			goto another_round;
		else if (unlikely(!skb))
			goto out;
	}

	rx_handler = rcu_dereference(skb->dev->rx_handler);
	if (rx_handler) {
		if (pt_prev) {
			ret = deliver_skb(skb, pt_prev, orig_dev);
			pt_prev = NULL;
		}
		switch (rx_handler(&skb)) {
		case RX_HANDLER_CONSUMED:
			ret = NET_RX_SUCCESS;
			goto out;
		case RX_HANDLER_ANOTHER:
			goto another_round;
		case RX_HANDLER_EXACT:
			deliver_exact = true;
		case RX_HANDLER_PASS:
			break;
		default:
			BUG();
		}
	}

What is the best way to address this issue? With VLAN hw acceleration,
skb_vlan_tag_present(skb) is true and rx_handler() is not called.

Thanks

-- 
Murali Karicheri
Texas Instruments

             reply	other threads:[~2020-08-19 16:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 16:08 Murali Karicheri [this message]
2020-08-21 15:10 ` Murali Karicheri
2020-08-21 15:54   ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcea193d-8143-a664-947c-8a1baea7bc2c@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: VLAN over HSR/PRP - Issue with rx_handler not called for VLAN hw acceleration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).