Netdev Archive on
help / color / mirror / Atom feed
From: Paolo Abeni <>
To: Coco Li <>
	Willem de Bruijn <>,
	Tanner Love <>
Subject: Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test
Date: Fri, 06 Aug 2021 09:49:53 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Thu, 2021-08-05 at 13:17 -0700, Coco Li wrote:
> > Have you considered additionally run the same test of top of a veth
> > pair, and have such tests always enabled, so we could have some
> > coverage regardless of specific H/W available?
> > To do the above you should disable TSO on the veth sender peer and
> > enable GRO on the other end.
> Thanks for the suggestion! To make sure I understand you correctly,
> would this be another script that creates the veth pair separate from
> the wrapper?

I personally don't have any strict preference. I *think* the veth
thing could still fit the script, but whatever is easier coding
wise would fit. 

The script with no/default argument could run all the tests on a
veth pair; if a device name is specified via the command line, it could
additionally run (the specified set of tests) on such device.



  parent reply	other threads:[~2021-08-06  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  7:36 [PATCH net-next 0/2] GRO and Toeplitz hash selftests Coco Li
2021-08-05  7:36 ` [PATCH net-next 1/2] selftests/net: GRO coalesce test Coco Li
2021-08-05 11:16   ` Paolo Abeni
2021-08-05 20:21     ` Coco Li
     [not found]     ` <>
2021-08-06  7:49       ` Paolo Abeni [this message]
2021-08-06 17:44         ` Coco Li
2021-08-05  7:36 ` [PATCH net-next 2/2] selftests/net: toeplitz test Coco Li
2021-08-05 12:30 ` [PATCH net-next 0/2] GRO and Toeplitz hash selftests patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).