Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steen Hegelund <steen.hegelund@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH net-next 1/2] net: sparx5: switchdev: adding frame DMA functionality
Date: Thu, 12 Aug 2021 09:04:24 +0200	[thread overview]
Message-ID: <e37f35e5ec73a7b7a3d6f692e0764411e74c7486.camel@microchip.com> (raw)
In-Reply-To: <20210811153132.63480934@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Hej Jacub,

On Wed, 2021-08-11 at 15:31 -0700, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, 11 Aug 2021 09:59:08 +0200 Steen Hegelund wrote:
> > This add frame DMA functionality to the Sparx5 platform.
> > 
> > Ethernet frames can be extracted or injected autonomously to or from the
> > device’s DDR3/DDR3L memory and/or PCIe memory space. Linked list data
> > structures in memory are used for injecting or extracting Ethernet frames.
> > The FDMA generates interrupts when frame extraction or injection is done
> > and when the linked lists need updating.
> 
> Something to fix:
> 
> drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c: In function ‘sparx5_fdma_start’:
> drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c:544:6: warning: variable ‘proc_ctrl’ set but
> not used [-Wunused-but-set-variable]
>   544 |  u32 proc_ctrl;
>       |      ^~~~~~~~~

Will do.

Thanks for the review.

BR
Steen


  reply	other threads:[~2021-08-12  7:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  7:59 [PATCH net-next 0/2] Adding Frame DMA functionality to Sparx5 Steen Hegelund
2021-08-11  7:59 ` [PATCH net-next 1/2] net: sparx5: switchdev: adding frame DMA functionality Steen Hegelund
2021-08-11 22:31   ` Jakub Kicinski
2021-08-12  7:04     ` Steen Hegelund [this message]
2021-08-11  7:59 ` [PATCH net-next 2/2] arm64: dts: sparx5: Add the Sparx5 switch frame DMA support Steen Hegelund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e37f35e5ec73a7b7a3d6f692e0764411e74c7486.camel@microchip.com \
    --to=steen.hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next 1/2] net: sparx5: switchdev: adding frame DMA functionality' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).