From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D1CC433F5 for ; Mon, 10 Jan 2022 13:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233045AbiAJNnH (ORCPT ); Mon, 10 Jan 2022 08:43:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:40275 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233016AbiAJNnG (ORCPT ); Mon, 10 Jan 2022 08:43:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641822186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWO8bUpZLUYe86Yo5GKizn940aDxxY2uX8Eua9eNw/E=; b=P8VDKf7md9bsBvDsZtM031TnKTLl7el8b5jHdHXIah7mKnQxQo6kKI+LFXqt8fDk06g/tX 2uP+VOVzObhPltjUlqRbb17iC6lbW5cuhWjxTwhiRWlZ2s8Xz/d7w1t/B8zgOIck6Tph7i BRRaSW3xgesCGL05CcsAKXFgCYVtP+Q= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-f-FOpRa6NLqjbUPMO-q4-A-1; Mon, 10 Jan 2022 08:43:05 -0500 X-MC-Unique: f-FOpRa6NLqjbUPMO-q4-A-1 Received: by mail-ot1-f69.google.com with SMTP id m23-20020a9d6457000000b0058f6f926cabso2680773otl.6 for ; Mon, 10 Jan 2022 05:43:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pWO8bUpZLUYe86Yo5GKizn940aDxxY2uX8Eua9eNw/E=; b=NeRlj9e1E5gkKoR2SlYqgUGXOZ2jIvxgK459abgIzhVR4hnwN2orwZvwPb9JO8cjQC Nv3K6wbrfcfV55cn0bqb8nZFD81KKhtyMPUPy5+2s4iSFRk9Gqn0veBhf25+9pkNDtMe 8szfFV/SkmgpPpk4dmw7CYF77kzgLdb0pLOkrc/QwIS+7sVTrvcD5tg+x0Sh/hrwkx+p w+Vnu9fhqeB34awWfPobm4DKReEOKP4nWAlBwHIdj1O3Ut0bok1w9AGCunY8ywoIq/zI PcC5zRd6qqVDZ4PANCzeleVQB+h/9/O08MzLhLkfVRPx/lKfIoGbiG3Fy4I49PsCmPxG bhzQ== X-Gm-Message-State: AOAM533PaOr+9RkUIxG7UN14lWU4rLhka3Npd4M8/pNGjg3DkSl/Hb95 xwVENHLHbDEVyYiuGj1mPDHKzLz1KzjJf35S51TN4o946y/tRyLh4r3rAYuFkhw1Lq2jJzHFoix XLXsVhi16+4bCljc9 X-Received: by 2002:a05:6830:4034:: with SMTP id i20mr7351278ots.243.1641822184453; Mon, 10 Jan 2022 05:43:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwra7ExUsBTMUvid99Z4eMEaJDEt12JpY0FwhcWLFMOignU8NPtKadY96Va2EYt/fw8qI/dxQ== X-Received: by 2002:a05:6830:4034:: with SMTP id i20mr7351243ots.243.1641822183935; Mon, 10 Jan 2022 05:43:03 -0800 (PST) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id z19sm661908oid.57.2022.01.10.05.43.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 05:43:03 -0800 (PST) Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix error checking in mtk_mac_config() To: Jakub Kicinski Cc: nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, davem@davemloft.net, matthias.bgg@gmail.com, linux@armlinux.org.uk, nathan@kernel.org, ndesaulniers@google.com, opensource@vdorst.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20220108155003.3991055-1-trix@redhat.com> <20220109164333.61dc2e89@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> From: Tom Rix Message-ID: Date: Mon, 10 Jan 2022 05:43:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220109164333.61dc2e89@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/9/22 4:43 PM, Jakub Kicinski wrote: > On Sat, 8 Jan 2022 07:50:03 -0800 trix@redhat.com wrote: >> From: Tom Rix >> >> Clang static analysis reports this problem >> mtk_eth_soc.c:394:7: warning: Branch condition evaluates >> to a garbage value >> if (err) >> ^~~ >> >> err is not initialized and only conditionally set. >> Check err consistently with the rest of mtk_mac_config(), >> after even possible setting. >> >> Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII") >> Signed-off-by: Tom Rix >> --- >> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> index b67b4323cff08..a27e548488584 100644 >> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c >> @@ -385,14 +385,16 @@ static void mtk_mac_config(struct phylink_config *config, unsigned int mode, >> 0 : mac->id; >> >> /* Setup SGMIISYS with the determined property */ >> - if (state->interface != PHY_INTERFACE_MODE_SGMII) >> + if (state->interface != PHY_INTERFACE_MODE_SGMII) { >> err = mtk_sgmii_setup_mode_force(eth->sgmii, sid, >> state); >> - else if (phylink_autoneg_inband(mode)) >> + if (err) >> + goto init_err; >> + } else if (phylink_autoneg_inband(mode)) { >> err = mtk_sgmii_setup_mode_an(eth->sgmii, sid); >> - >> - if (err) >> - goto init_err; >> + if (err) >> + goto init_err; >> + } >> >> regmap_update_bits(eth->ethsys, ETHSYS_SYSCFG0, >> SYSCFG0_SGMII_MASK, val); > Why not init err to 0 before the if or add an else err = 0; branch? This is the way I would have preferred to do it but the function's existing error handling does it this way. I'll respin the patch. Tom >