From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FC7C4320E for ; Tue, 3 Aug 2021 17:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94F3061102 for ; Tue, 3 Aug 2021 17:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238551AbhHCR7Y (ORCPT ); Tue, 3 Aug 2021 13:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238536AbhHCR7X (ORCPT ); Tue, 3 Aug 2021 13:59:23 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE43C061757; Tue, 3 Aug 2021 10:59:10 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id e25-20020a05600c4b99b0290253418ba0fbso2640090wmp.1; Tue, 03 Aug 2021 10:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NdNGEZnkIReFGRbvKm7ES1u0aHYUQFB1OavFTkgaq4o=; b=S86myK+6wWO63bssW2t/9Ng2YNvM1DFL4Vtdr/rDo2rs9MJXbhBWtfF2Ptepnkl6VS guGewDmpFD+yPsGZ4dN+pr25yEMROllw1Q3F3fSxDMdorfBRyYAd3pv+HP3srtKgXPYB 2dVfriMo7iObMBviKv5rPusKHYi3ia6PFO78qIwpx9Emyh6UHM6cE8sgZEg911JJHjcB tDcjkp7ntLiZBmpLd7pqtU88/TXcLXGvuGc8c/V072aaNuk5nKxLyzfF3ZXRaDgGZSZb gpj4D6k80XJ38Vlntwq96OeXhrSPJ7HmhObzQ8z8z7YMAQ27VVTE9nqgQEp4u224Vt3s 0gwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NdNGEZnkIReFGRbvKm7ES1u0aHYUQFB1OavFTkgaq4o=; b=cveeQTpR4LaPSyuCYqFzdoji0yAnj6dy2V5crAl2k+AH/kkOyps+7PL5qaEY54ho8m IC3uiGRGedwF2aw64EQMFFkMps+F1/d4JSTXFWui01jfX2SI2ri2XrLNle7bpxuioaDL wP3F/XVVdshqaP7GOmRb44+mBxo2+/9n+k/ovj98NRWG4sN1rzdNO57yngRjQ71B6C0R /0ySytDjaPNKNvg2Mh33DFqouO/pGv8pWSqqyY5W8E2h2nwhcIi2ufv+KMJwe399TxNt oVesdSCUByjGemMCauUv5vSa0qGDIBmFgJURdiJjYAo9hdQNZ+FTHLfCCa+/7/4gIXkg 96TA== X-Gm-Message-State: AOAM533axo4sPElS366IqZ0BhqFC5z9V6tOEQAu9ppPv7ztbcWb+Zpxt RxRcTKnW99PNCsQxqC8VF4A0Clq6Q6MOaHnICQU= X-Google-Smtp-Source: ABdhPJzidk6XmSHAiRFyVpv/tKzpVGxZGGy99rtgjo6zlmzKZQOEf1GDLPy4rW24nhDKfEwMN+wcxw== X-Received: by 2002:a05:600c:35d6:: with SMTP id r22mr5504280wmq.41.1628013549063; Tue, 03 Aug 2021 10:59:09 -0700 (PDT) Received: from [80.5.213.92] (cpc108963-cmbg20-2-0-cust347.5-4.cable.virginm.net. [80.5.213.92]) by smtp.gmail.com with ESMTPSA id l7sm13629417wmj.9.2021.08.03.10.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 10:59:08 -0700 (PDT) Subject: Re: [PATCH net-next 13/21] ethernet, sfc: convert to standard XDP stats To: Alexander Lobakin , "David S. Miller" , Jakub Kicinski Cc: Jesse Brandeburg , Lukasz Czapnik , Marcin Kubiak , Michal Kubiak , Michal Swiatkowski , Jonathan Corbet , Netanel Belgazal , Arthur Kiyanovski , Guy Tzalik , Saeed Bishara , Ioana Ciornei , Claudiu Manoil , Thomas Petazzoni , Marcin Wojtas , Russell King , Martin Habets , "Michael S. Tsirkin" , Jason Wang , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Shay Agroskin , Sameeh Jubran , Alexander Duyck , Danielle Ratson , Ido Schimmel , Andrew Lunn , Vladyslav Tarasiuk , Arnd Bergmann , Andrew Morton , Jian Shen , Petr Vorel , Dan Murphy , Yangbo Lu , Michal Kubecek , Zheng Yongjun , Heiner Kallweit , YueHaibing , Johannes Berg , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, bpf@vger.kernel.org References: <20210803163641.3743-1-alexandr.lobakin@intel.com> <20210803163641.3743-14-alexandr.lobakin@intel.com> From: Edward Cree Message-ID: Date: Tue, 3 Aug 2021 18:59:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210803163641.3743-14-alexandr.lobakin@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/08/2021 17:36, Alexander Lobakin wrote: > Just like DPAA2 driver, EF{100,X} store XDP stats per-channel, but > present them as the sums across all channels. > Switch to the standard per-channel XDP stats. n_rx_xdp_bad_drops > goes as "general XDP errors", because driver uses just one counter > for all kinds of errors. > > Signed-off-by: Alexander Lobakin > Reviewed-by: Jesse Brandeburg Acked-by: Edward Cree