Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Cong Wang <xiyou.wangcong@gmail.com>, Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>, Jon Maloy <jmaloy@redhat.com>,
	Ying Xue <ying.xue@windriver.com>,
	tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module
Date: Mon, 17 Aug 2020 11:49:09 -0700	[thread overview]
Message-ID: <f46edd0e-f44c-e600-2026-2d2ca960a94b@infradead.org> (raw)
In-Reply-To: <CAM_iQpWQ6um=-oYK4_sgY3=3PsV1GEgCfGMYXANJ-spYRcz2XQ@mail.gmail.com>

On 8/17/20 11:31 AM, Cong Wang wrote:
> On Sun, Aug 16, 2020 at 11:37 PM Xin Long <lucien.xin@gmail.com> wrote:
>>
>> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>
>>> Or put it into struct ipv6_stub?
>> Hi Cong,
>>
>> That could be one way. We may do it when this new function becomes more common.
>> By now, I think it's okay to make TIPC depend on IPV6 || IPV6=n.
> 
> I am not a fan of IPV6=m, but disallowing it for one symbol seems
> too harsh.

Hi,

Maybe I'm not following you, but this doesn't disallow IPV6=m.

It just restricts how TIPC can be built, so that
TIPC=y and IPV6=m cannot happen together, which causes
a build error.

-- 
~Randy


  reply	other threads:[~2020-08-17 18:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16  9:32 Xin Long
2020-08-16 18:29 ` Cong Wang
2020-08-17  6:49   ` Xin Long
2020-08-17 18:31     ` Cong Wang
2020-08-17 18:49       ` Randy Dunlap [this message]
2020-08-17 18:55         ` Cong Wang
2020-08-17 19:00           ` Randy Dunlap
2020-08-17 19:26             ` Cong Wang
2020-08-17 19:55               ` Randy Dunlap
2020-08-17 20:29                 ` Cong Wang
2020-08-17 20:43                   ` Randy Dunlap
2020-08-17 20:59                     ` Cong Wang
2020-08-17 21:39                       ` David Miller
2020-08-17 22:20                         ` Cong Wang
2020-08-18  7:59                           ` Xin Long
2020-08-17 21:37                   ` David Miller
2020-08-17 21:34           ` David Miller
2020-08-17  4:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f46edd0e-f44c-e600-2026-2d2ca960a94b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=davem@davemloft.net \
    --cc=jmaloy@redhat.com \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=xiyou.wangcong@gmail.com \
    --cc=ying.xue@windriver.com \
    --subject='Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).