Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Toppins <jtoppins@redhat.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	davem@davemloft.net, kuba@kernel.org
Cc: Brett Creeley <brett.creeley@intel.com>,
	netdev@vger.kernel.org, Liang Li <liali@redhat.com>,
	Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net 3/4] ice: don't remove netdev->dev_addr from uc sync list
Date: Tue, 10 Aug 2021 10:29:12 -0400	[thread overview]
Message-ID: <f6c250c2-392b-a898-9e03-167d771cad94@redhat.com> (raw)
In-Reply-To: <20210809171402.17838-4-anthony.l.nguyen@intel.com>

On 8/9/21 1:14 PM, Tony Nguyen wrote:
> From: Brett Creeley <brett.creeley@intel.com>
> 
> In some circumstances, such as with bridging, it's possible that the
> stack will add the device's own MAC address to its unicast address list.
> 
> If, later, the stack deletes this address, the driver will receive a
> request to remove this address.
> 
> The driver stores its current MAC address as part of the VSI MAC filter
> list instead of separately. So, this causes a problem when the device's
> MAC address is deleted unexpectedly, which results in traffic failure in
> some cases.
> 
> The following configuration steps will reproduce the previously
> mentioned problem:
> 
>> ip link set eth0 up
>> ip link add dev br0 type bridge
>> ip link set br0 up
>> ip addr flush dev eth0
>> ip link set eth0 master br0
>> echo 1 > /sys/class/net/br0/bridge/vlan_filtering
>> modprobe -r veth
>> modprobe -r bridge
>> ip addr add 192.168.1.100/24 dev eth0
> 
> The following ping command fails due to the netdev->dev_addr being
> deleted when removing the bridge module.
>> ping <link partner>
> 
> Fix this by making sure to not delete the netdev->dev_addr during MAC
> address sync. After fixing this issue it was noticed that the
> netdev_warn() in .set_mac was overly verbose, so make it at
> netdev_dbg().
> 
> Also, there is a possibility of a race condition between .set_mac and
> .set_rx_mode. Fix this by calling netif_addr_lock_bh() and
> netif_addr_unlock_bh() on the device's netdev when the netdev->dev_addr
> is going to be updated in .set_mac.
> 
> Fixes: e94d44786693 ("ice: Implement filter sync, NDO operations and bump version")
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
> Tested-by: Liang Li <liali@redhat.com>
> Tested-by: Gurucharan G <gurucharanx.g@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Tested-by: Jonathan Toppins <jtoppins@redhat.com>


  reply	other threads:[~2021-08-10 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 17:13 [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2021-08-09 Tony Nguyen
2021-08-09 17:13 ` [PATCH net 1/4] ice: Prevent probing virtual functions Tony Nguyen
2021-08-09 22:56   ` Jakub Kicinski
2021-08-09 17:14 ` [PATCH net 2/4] ice: Stop processing VF messages during teardown Tony Nguyen
2021-08-09 22:58   ` Jakub Kicinski
2021-08-10 17:42     ` Venkataramanan, Anirudh
2021-08-10 14:30   ` Jonathan Toppins
2021-08-09 17:14 ` [PATCH net 3/4] ice: don't remove netdev->dev_addr from uc sync list Tony Nguyen
2021-08-10 14:29   ` Jonathan Toppins [this message]
2021-08-09 17:14 ` [PATCH net 4/4] iavf: Set RSS LUT and key in reset handle path Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6c250c2-392b-a898-9e03-167d771cad94@redhat.com \
    --to=jtoppins@redhat.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=brett.creeley@intel.com \
    --cc=davem@davemloft.net \
    --cc=gurucharanx.g@intel.com \
    --cc=kuba@kernel.org \
    --cc=liali@redhat.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net 3/4] ice: don'\''t remove netdev->dev_addr from uc sync list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).