Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jie Luo <luoj@codeaurora.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
	davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
	hkallweit1@gmail.com, linux@armlinux.org.uk,
	robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO driver
Date: Thu, 12 Aug 2021 10:39:51 +0800	[thread overview]
Message-ID: <fb49c1e3-c4f6-0d72-0def-8cae734fc3ff@codeaurora.org> (raw)
In-Reply-To: <YRPlZGXWJGoLRSSN@lunn.ch>


On 8/11/2021 10:57 PM, Andrew Lunn wrote:
>> +	ret = clk_prepare_enable(priv->mdio_clk);
>> +	if (ret)
>> +		return ret;
>> +
>> +	return 0;
> This can be simplified to just:
>
>       return clk_prepare_enable(priv->mdio_clk);
>
>       Andrew
Thanks Andrew for the comments, will update it in the next patch set.

  reply	other threads:[~2021-08-12  2:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 13:31 [PATCH v2 0/3] net: mdio: Add IPQ MDIO reset related function Luo Jie
2021-08-10 13:31 ` [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO driver Luo Jie
2021-08-11 14:57   ` Andrew Lunn
2021-08-12  2:39     ` Jie Luo [this message]
2021-08-10 13:31 ` [PATCH v2 2/3] MDIO: Kconfig: Specify more IPQ chipset supported Luo Jie
2021-08-11 14:58   ` Andrew Lunn
2021-08-10 13:31 ` [PATCH v2 3/3] dt-bindings: net: Add the properties for ipq4019 MDIO Luo Jie
2021-08-11 14:58   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb49c1e3-c4f6-0d72-0def-8cae734fc3ff@codeaurora.org \
    --to=luoj@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=sricharan@codeaurora.org \
    --subject='Re: [PATCH v2 1/3] net: mdio: Add the reset function for IPQ MDIO driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).