From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA45C433E6 for ; Fri, 28 Aug 2020 10:43:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CC842098B for ; Fri, 28 Aug 2020 10:43:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=piap.pl header.i=@piap.pl header.b="OoDPMwtJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729124AbgH1KnS (ORCPT ); Fri, 28 Aug 2020 06:43:18 -0400 Received: from ni.piap.pl ([195.187.100.5]:41266 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728218AbgH1KnO (ORCPT ); Fri, 28 Aug 2020 06:43:14 -0400 X-Greylist: delayed 330 seconds by postgrey-1.27 at vger.kernel.org; Fri, 28 Aug 2020 06:43:12 EDT Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ni.piap.pl (Postfix) with ESMTPSA id 0E631442480; Fri, 28 Aug 2020 12:37:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 0E631442480 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=piap.pl; s=mail; t=1598611058; bh=mX0r45ob5AWEtdzdyfUiUKYeTekKi7l1NPoWWKilQlM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OoDPMwtJFpQc2LrfhaaKDD+q447F4tx4ZJIgcWgin8MXQFyoe/ma+LcEzzIaf0pkR bFoLkUIoCJ9LpCjRDDPiALP5H+B6obenk7u2NHdYrUemrqSsxY8lkWIXacpxh55Vyo KTRPVV7xsjc2BjcBmM/h+1+HMgxj81wqtrNwFIw8= From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Xie He Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Schiller Subject: Re: [PATCH net] drivers/net/wan/hdlc_cisco: Add hard_header_len References: <20200828070752.54444-1-xie.he.0141@gmail.com> Date: Fri, 28 Aug 2020 12:37:37 +0200 In-Reply-To: <20200828070752.54444-1-xie.he.0141@gmail.com> (Xie He's message of "Fri, 28 Aug 2020 00:07:52 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-KLMS-Rule-ID: 4 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, not scanned, whitelist Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Xie, Xie He writes: > This driver didn't set hard_header_len. This patch sets hard_header_len > for it according to its header_ops->create function. BTW it's 4 bytes long: struct hdlc_header { u8 address; u8 control; __be16 protocol; }__packed; OTOH hdlc_setup_dev() initializes hard_header_len to 16, but in this case I guess 4 bytes are better. Acked-by: Krzysztof Halasa > Cc: Martin Schiller > Signed-off-by: Xie He > --- > --- a/drivers/net/wan/hdlc_cisco.c > +++ b/drivers/net/wan/hdlc_cisco.c > @@ -370,6 +370,7 @@ static int cisco_ioctl(struct net_device *dev, struct= ifreq *ifr) > memcpy(&state(hdlc)->settings, &new_settings, size); > spin_lock_init(&state(hdlc)->lock); > dev->header_ops =3D &cisco_header_ops; > + dev->hard_header_len =3D sizeof(struct hdlc_header); > dev->type =3D ARPHRD_CISCO; > call_netdevice_notifiers(NETDEV_POST_TYPE_CHANGE, dev); > netif_dormant_on(dev); --=20 Krzysztof Halasa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa