Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Conley Lee <conleylee@foxmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org,
wens@csie.org, clabbe.montjoie@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number with macro
Date: Mon, 10 Jan 2022 22:42:02 +0800 [thread overview]
Message-ID: <tencent_6DDF530ADA4A09B6D49B4E0A8CD9F23D7809@qq.com> (raw)
In-Reply-To: <YdwvEKiKd0JKpG9T@unreal>
On 01/10/22 at 03:05下午, Leon Romanovsky wrote:
> Date: Mon, 10 Jan 2022 15:05:20 +0200
> From: Leon Romanovsky <leon@kernel.org>
> To: Conley Lee <conleylee@foxmail.com>
> Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org,
> wens@csie.org, clabbe.montjoie@gmail.com, netdev@vger.kernel.org,
> linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number
> with macro
>
> On Mon, Jan 10, 2022 at 07:35:49PM +0800, Conley Lee wrote:
> > This patch remove magic numbers in sun4i-emac.c and replace with macros
> > defined in sun4i-emac.h
> >
> > Change since v1
> > ---------------
> > - reformat
> > - merge commits
> > - add commit message
>
> This changelog should be placed after "---" below your SOB.
>
> Thanks
>
> >
> > Signed-off-by: Conley Lee <conleylee@foxmail.com>
> > ---
> > drivers/net/ethernet/allwinner/sun4i-emac.c | 30 ++++++++++++---------
> > drivers/net/ethernet/allwinner/sun4i-emac.h | 18 +++++++++++++
> > 2 files changed, 35 insertions(+), 13 deletions(-)
I will reformat it and submit again, thanks ~
next prev parent reply other threads:[~2022-01-10 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 7:23 [PATCH 0/2] sun4i-emac: replace magic number with marcos conleylee
2022-01-10 8:32 ` Corentin Labbe
2022-01-10 11:35 ` [PATCH v2] net: ethernet: sun4i-emac: replace magic number with macro Conley Lee
2022-01-10 13:05 ` Leon Romanovsky
2022-01-10 14:42 ` Conley Lee [this message]
2022-01-10 13:31 ` Andrew Lunn
2022-01-10 14:40 ` Conley Lee
2022-01-10 13:56 ` Corentin Labbe
2022-01-10 17:28 ` Jakub Kicinski
2022-01-11 3:19 ` Conley Lee
2022-01-11 3:05 ` [PATCH v3] " Conley Lee
2022-01-11 16:32 ` Corentin Labbe
2022-01-12 6:16 ` Conley Lee
2022-01-12 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_6DDF530ADA4A09B6D49B4E0A8CD9F23D7809@qq.com \
--to=conleylee@foxmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
--subject='Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number with macro' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).